Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for podcast image i n Picture.tsx #12568

Merged
merged 17 commits into from
Oct 24, 2024
Merged

Add support for podcast image i n Picture.tsx #12568

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6ab4692
Revert "Revert "Create new `PodcastMeta` component ""
oliverabrahams Oct 2, 2024
4ca44c5
fixed a few errors
oliverabrahams Oct 15, 2024
e71ca74
Merge branch 'main' into e2e/podcast-tags
oliverabrahams Oct 15, 2024
fb27194
add podcast cover image first attempt
oliverabrahams Oct 15, 2024
124a238
Add podcast image to StandardLayout.tsx
oliverabrahams Oct 16, 2024
253b8ce
update picture component to accept custom roleType
oliverabrahams Oct 17, 2024
0c0fa28
cascade wrong way round ):
oliverabrahams Oct 17, 2024
45e10b9
Merge branch 'main' into e2e/podcast-tags
oliverabrahams Oct 17, 2024
b1af9fd
Merge branch 'e2e/podcast-tags' into e2e/podcast-cover-image
oliverabrahams Oct 17, 2024
33fcb0f
fix merge
oliverabrahams Oct 17, 2024
391ded9
Merge branch 'main' into e2e/podcast-cover-image
oliverabrahams Oct 21, 2024
26e4f0f
Update picture to add new role type, Keeping the decideImageWidths as…
oliverabrahams Oct 22, 2024
52bc208
Update picture to add new role type, Keeping the decideImageWidths as…
oliverabrahams Oct 22, 2024
d724c62
Add comment explaining custom role types
oliverabrahams Oct 22, 2024
23cc773
update series tag name
oliverabrahams Oct 24, 2024
3664823
rollback changes to layout as these are in a different PR
oliverabrahams Oct 24, 2024
f115221
Merge branch 'main' into e2e/podcast-cover-image
oliverabrahams Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions dotcom-rendering/src/components/Picture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@ import type { Loading } from './CardPicture';

export type Orientation = 'portrait' | 'landscape';

type PictureRoleType =
| RoleType
// Custom image role types that are used but do not come from CAPI / FE
| 'podcastCover';

type Props = {
role: RoleType;
role: PictureRoleType;
format: ArticleFormat;
master: string;
alt: string;
Expand Down Expand Up @@ -54,7 +59,7 @@ const decideImageWidths = ({
isLightbox,
orientation,
}: {
role: RoleType;
role: PictureRoleType;
isMainMedia?: boolean;
format: ArticleFormat;
isLightbox: boolean;
Expand Down Expand Up @@ -163,6 +168,11 @@ const decideImageWidths = ({
case 'supporting':
case 'halfWidth':
return [{ breakpoint: breakpoints.mobile, width: 445 }];
case 'podcastCover':
return [
{ breakpoint: breakpoints.mobile, width: 140 },
{ breakpoint: breakpoints.wide, width: 219 },
];
case 'inline':
default:
return [
Expand Down
Loading