Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for podcast image i n Picture.tsx #12568

Merged
merged 17 commits into from
Oct 24, 2024
Merged

Add support for podcast image i n Picture.tsx #12568

merged 17 commits into from
Oct 24, 2024

Commits on Oct 2, 2024

  1. Revert "Revert "Create new PodcastMeta component "" 

    This reverts commit 2f40922.
    @oliverabrahams
    oliverabrahams committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6ab4692 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. fixed a few errors

    @oliverabrahams
    oliverabrahams committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4ca44c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into e2e/podcast-tags

    @oliverabrahams
    oliverabrahams authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e71ca74 View commit details
    Browse the repository at this point in the history

  3. add podcast cover image first attempt

    @oliverabrahams
    oliverabrahams committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fb27194 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Add podcast image to StandardLayout.tsx

    @oliverabrahams
    oliverabrahams committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    124a238 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. update picture component to accept custom roleType

    @oliverabrahams
    oliverabrahams committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    253b8ce View commit details
    Browse the repository at this point in the history

  2. cascade wrong way round ):

    @oliverabrahams
    oliverabrahams committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    0c0fa28 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into e2e/podcast-tags 

    # Conflicts:
#	dotcom-rendering/src/layouts/StandardLayout.tsx
    @oliverabrahams
    oliverabrahams committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    45e10b9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'e2e/podcast-tags' into e2e/podcast-cover-image 

    # Conflicts:
#	dotcom-rendering/src/components/Picture.tsx
#	dotcom-rendering/src/layouts/StandardLayout.tsx
    @oliverabrahams
    oliverabrahams committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b1af9fd View commit details
    Browse the repository at this point in the history

  5. fix merge

    @oliverabrahams
    oliverabrahams committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    33fcb0f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge branch 'main' into e2e/podcast-cover-image 

    # Conflicts:
#	dotcom-rendering/src/components/ArticleMeta.web.tsx
    @oliverabrahams
    oliverabrahams committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    391ded9 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Update picture to add new role type, Keeping the decideImageWidths as… 

    … the source of truth for image widths
    @oliverabrahams
    oliverabrahams committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    26e4f0f View commit details
    Browse the repository at this point in the history

  2. Update picture to add new role type, Keeping the decideImageWidths as… 

    … the source of truth for image widths
    @oliverabrahams
    oliverabrahams committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    52bc208 View commit details
    Browse the repository at this point in the history

  3. Add comment explaining custom role types

    @oliverabrahams
    oliverabrahams committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d724c62 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. update series tag name

    @oliverabrahams
    oliverabrahams committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    23cc773 View commit details
    Browse the repository at this point in the history

  2. rollback changes to layout as these are in a different PR

    @oliverabrahams
    oliverabrahams committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    3664823 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into e2e/podcast-cover-image

    @oliverabrahams
    oliverabrahams authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f115221 View commit details
    Browse the repository at this point in the history