Support Galaxies move to hiring/onboarding AWS account #35
+16
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
force-pushed
the
support-galaxies-aws-account-change
branch
4 times, most recently
from
7e200fc to
39ff798
Compare
Co-Authored-By: Tom Richards <[email protected]>
twrichards
force-pushed
the
support-galaxies-aws-account-change
branch
from
39ff798 to
acbbc8c
Compare
AshCorr
approved these changes
Jul 1, 2024
| @@ -35,7 +34,7 @@ | |||
| "@guardian/cdk": "48.5.1", | |||
| "@guardian/eslint-config-typescript": "^1.0.11", | |||
| "@guardian/prettier": "^2.0.0", | |||
| "@guardian/private-infrastructure-config": "git+ssh://git@github.com/guardian/private-infrastructure-config.git#v2.1.3", | |||
| "@guardian/private-infrastructure-config": "github:guardian/private-infrastructure-config#c6159b4a0a09d4f3a7a978a6fd48e37b1a2c8e3b", | |||
There was a problem hiding this comment.
Does this need to be switched back to point at a branch now?
There was a problem hiding this comment.
not sure if @akash1810 made any progress on changing the release mechanism?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @twrichards
In #14 and #20 we added the ability for galaxies data-refresher-lambda in a different account (playground) to upload data files to the galaxies static site (in the actions static site bucket).
The galaxies data-refresher-lambda is moving to a more stable home in the new 'Hiring & Onboarding' account, this updates those permissions accordingly (which requires https://github.com/guardian/private-infrastructure-config/pull/58, https://github.com/guardian/private-infrastructure-config/pull/59, https://github.com/guardian/private-infrastructure-config/pull/61)