Skip to content

Commit

Permalink
Support Galaxies move to hiring/onboarding AWS account
Browse files Browse the repository at this point in the history
Co-Authored-By: Tom Richards <[email protected]>
  • Loading branch information
frederickobrien and twrichards committed Jun 27, 2024
1 parent 33c5f0f commit acbbc8c
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 17 deletions.
12 changes: 6 additions & 6 deletions cdk/__snapshots__/infra.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1185,7 +1185,7 @@ systemctl start app
"Action": "s3:PutObject",
"Effect": "Allow",
"Principal": Object {
"AWS": "arn:aws:iam::000000000016:role/galaxies-data-refresher-lambda-role-PROD",
"AWS": "arn:aws:iam::000000000035:role/galaxies-data-refresher-lambda-role-PROD",
},
"Resource": Object {
"Fn::Join": Array [
Expand Down Expand Up @@ -1213,7 +1213,7 @@ systemctl start app
},
"Effect": "Allow",
"Principal": Object {
"AWS": "arn:aws:iam::000000000016:role/galaxies-data-refresher-lambda-role-PROD",
"AWS": "arn:aws:iam::000000000035:role/galaxies-data-refresher-lambda-role-PROD",
},
"Resource": Object {
"Fn::GetAtt": Array [
Expand All @@ -1235,11 +1235,11 @@ systemctl start app
Object {
"Ref": "AWS::Partition",
},
":iam::000000000016:root",
":iam::000000000035:root",
],
],
},
"arn:aws:iam::000000000016:role/galaxies-data-refresher-lambda-role-CODE",
"arn:aws:iam::000000000035:role/galaxies-data-refresher-lambda-role-CODE",
],
},
"Resource": Object {
Expand Down Expand Up @@ -1277,11 +1277,11 @@ systemctl start app
Object {
"Ref": "AWS::Partition",
},
":iam::000000000016:root",
":iam::000000000035:root",
],
],
},
"arn:aws:iam::000000000016:role/galaxies-data-refresher-lambda-role-CODE",
"arn:aws:iam::000000000035:role/galaxies-data-refresher-lambda-role-CODE",
],
},
"Resource": Object {
Expand Down
6 changes: 3 additions & 3 deletions cdk/infra.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,16 @@ systemctl start ${app}
prefix: 'galaxies.gutools.co.uk/data/*',
principals: [
new ArnPrincipal(
`arn:aws:iam::${GuardianAwsAccounts.DeveloperPlayground}:role/galaxies-data-refresher-lambda-role-PROD`,
`arn:aws:iam::${GuardianAwsAccounts.HiringAndOnboarding}:role/galaxies-data-refresher-lambda-role-PROD`,
),
],
},
CODE: {
prefix: 'galaxies.code.dev-gutools.co.uk/data/*',
principals: [
new AccountPrincipal(GuardianAwsAccounts.DeveloperPlayground), // for local development
new AccountPrincipal(GuardianAwsAccounts.HiringAndOnboarding), // for local development
new ArnPrincipal(
`arn:aws:iam::${GuardianAwsAccounts.DeveloperPlayground}:role/galaxies-data-refresher-lambda-role-CODE`,
`arn:aws:iam::${GuardianAwsAccounts.HiringAndOnboarding}:role/galaxies-data-refresher-lambda-role-CODE`,
),
],
},
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@
},
"author": "[email protected]",
"license": "ISC",
"eslintConfig": {
"eslintConfig": {
"extends": "@guardian/eslint-config-typescript"
},
"eslintIgnore": [
"packages/common/dist"
],
"prettier": "@guardian/prettier",

"dependencies": {
"@actions/artifact": "^1.1.0",
"@actions/core": "^1.6.0",
Expand All @@ -35,7 +34,7 @@
"@guardian/cdk": "48.5.1",
"@guardian/eslint-config-typescript": "^1.0.11",
"@guardian/prettier": "^2.0.0",
"@guardian/private-infrastructure-config": "git+ssh://git@github.com/guardian/private-infrastructure-config.git#v2.1.3",
"@guardian/private-infrastructure-config": "github:guardian/private-infrastructure-config#c6159b4a0a09d4f3a7a978a6fd48e37b1a2c8e3b",
"@types/jest": "^27.4.1",
"@types/js-yaml": "^4.0.5",
"@types/node": "^17.0.23",
Expand Down

0 comments on commit acbbc8c

Please sign in to comment.