Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cart): fix factory partial types #1834

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: test

What is the current behavior?

Some cart tests break the cart type during factory invocation.

What is the new behavior?

Factory partial types are now correct.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 force-pushed the test/cart/fix-factory-partial-types branch from 3d78488 to 229eaa8 Compare December 2, 2021 03:58
@griest024 griest024 force-pushed the test/cart/fix-factory-partial-types branch from 229eaa8 to 0208abb Compare November 23, 2023 18:24
@griest024 griest024 merged commit ef17259 into develop Nov 24, 2023
17 checks passed
@griest024 griest024 deleted the test/cart/fix-factory-partial-types branch November 24, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: cart @daffodil/cart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants