test(cart): fix factory partial types (#1834)

libs/cart-store-credit/testing/src/factories/cart-with-store-credit.factory.ts

@@ -3,6 +3,7 @@ import { faker } from '@faker-js/faker';
 
 import { MockCart } from '@daffodil/cart/testing';
 import { DaffCartTotalFactory } from '@daffodil/cart/testing';
+import { DaffCartShippingInformationFactory } from '@daffodil/cart/testing';
 import { DaffCartWithStoreCredit } from '@daffodil/cart-store-credit';
 import { DaffModelFactory } from '@daffodil/core/testing';
 
@@ -22,7 +23,8 @@ export class MockDaffCartWithStoreCredit extends MockCart implements DaffCartWit
 export class DaffCartWithStoreCreditFactory extends DaffModelFactory<DaffCartWithStoreCredit>{
   constructor(
     totalFactory: DaffCartTotalFactory,
+    shippingInformationFactory: DaffCartShippingInformationFactory,
   ) {
-    super(MockDaffCartWithStoreCredit, totalFactory);
+    super(MockDaffCartWithStoreCredit, totalFactory, shippingInformationFactory);
   }
 }

libs/cart/driver/magento/src/transforms/outputs/cart-totals-transformer.spec.ts

@@ -2,26 +2,36 @@ import { TestBed } from '@angular/core/testing';
 
 import { DaffCartTotalTypeEnum } from '@daffodil/cart';
 import { MagentoCart } from '@daffodil/cart/driver/magento';
-import { MagentoCartFactory } from '@daffodil/cart/driver/magento/testing';
+import {
+  MagentoCartFactory,
+  MagentoCartShippingMethodFactory,
+  MagentoShippingAddressFactory,
+} from '@daffodil/cart/driver/magento/testing';
 import { daffAdd } from '@daffodil/core';
 
 import { transformCartTotals } from './cart-totals-transformer';
 
 describe('transformCartTotals', () => {
+  let magentoShippingAddressFactory: MagentoShippingAddressFactory;
+  let magentoShippingMethodFactory: MagentoCartShippingMethodFactory;
+
   let stubMagentoCart: MagentoCart;
 
   beforeEach(() => {
     TestBed.configureTestingModule({});
 
+    magentoShippingAddressFactory = TestBed.inject(MagentoShippingAddressFactory);
+    magentoShippingMethodFactory = TestBed.inject(MagentoCartShippingMethodFactory);
     stubMagentoCart = TestBed.inject(MagentoCartFactory).create({
       shipping_addresses: [
-        {
-          selected_shipping_method: {
+        magentoShippingAddressFactory.create({
+          selected_shipping_method: magentoShippingMethodFactory.create({
             amount: {
               value: 100,
+              currency: 'USD',
             },
-          },
-        },
+          }),
+        }),
       ],
     });
   });

libs/cart/driver/magento/src/transforms/outputs/cart.service.spec.ts

@@ -109,13 +109,14 @@ describe('@daffodil/cart/driver/magento | MagentoCart', () => {
     mockDaffCart = daffCartFactory.create();
     mockMagentoCart = magentoCartFactory.create({
       shipping_addresses: [
-        {
-          selected_shipping_method: {
+        magentoShippingAddressFactory.create({
+          selected_shipping_method: magentoShippingMethodFactory.create({
             amount: {
               value: 100,
+              currency: 'USD',
             },
-          },
-        },
+          }),
+        }),
       ],
     });
     mockShippingAddress = {

libs/cart/routing/src/guards/shipping-method/shipping-method.guard.spec.ts

@@ -52,9 +52,7 @@ describe('Cart | State | Guards | DaffShippingMethodGuard', () => {
 
   describe('canActivate', () => {
     it('should allow activation when there is a shipping method', () => {
-      const cart: DaffCart = TestBed.inject(DaffCartFactory).create({
-        shipping_information: new DaffCartShippingRateFactory().create(),
-      });
+      const cart: DaffCart = TestBed.inject(DaffCartFactory).create();
       store.dispatch(new DaffCartLoadSuccess(cart));
       const expected = cold('(a|)', { a: true });
 

libs/cart/routing/src/resolvers/empty-cart-resolver.service.spec.ts

@@ -107,7 +107,7 @@ describe('DaffEmptyCartResolver', () => {
             done();
           });
 
-          stubCart = cartFactory.create({ items: cartItemFactory.create() });
+          stubCart = cartFactory.create({ items: cartItemFactory.createMany(1) });
           cartResolverSubject.next(stubCart);
         });
       });

libs/cart/state/src/facades/cart/cart.facade.spec.ts

@@ -1614,7 +1614,10 @@ describe('DaffCartFacade', () => {
     describe('when all the shipping method is present', () => {
       beforeEach(() => {
         const cart: DaffCart = cartFactory.create({
-          shipping_information: shippingMethodFactory.create(),
+          shipping_information: {
+            address_id: 'id',
+            ...shippingMethodFactory.create(),
+          },
         });
         facade.dispatch(new DaffCartLoadSuccess(cart));
       });
@@ -1660,7 +1663,10 @@ describe('DaffCartFacade', () => {
           shipping_address: cartAddressFactory.create(),
           billing_address: cartAddressFactory.create(),
           payment: paymentFactory.create(),
-          shipping_information: shippingMethodFactory.create(),
+          shipping_information: {
+            address_id: 'id',
+            ...shippingMethodFactory.create(),
+          },
         });
         facade.dispatch(new DaffCartLoadSuccess(cart));
       });

libs/cart/state/src/selectors/cart/cart.selector.spec.ts

@@ -48,7 +48,6 @@ import {
   DaffCartItemFactory,
   DaffCartAddressFactory,
   DaffCartPaymentFactory,
-  DaffCartShippingRateFactory,
 } from '@daffodil/cart/testing';
 import {
   DaffState,
@@ -57,14 +56,13 @@ import {
 
 import { getCartSelectors } from './cart.selector';
 
-describe('Cart | Selector | Cart', () => {
+describe('@daffodil/cart/state | getCartSelectors', () => {
   let store: Store<DaffCartStateRootSlice>;
 
   let cartFactory: DaffCartFactory;
   let cartItemFactory: DaffCartItemFactory;
   let cartAddressFactory: DaffCartAddressFactory;
   let paymentFactory: DaffCartPaymentFactory;
-  let shippingMethodFactory: DaffCartShippingRateFactory;
 
   let orderId: string;
   let cart: DaffCart;
@@ -163,7 +161,6 @@ describe('Cart | Selector | Cart', () => {
     cartItemFactory = TestBed.inject(DaffCartItemFactory);
     cartAddressFactory = TestBed.inject(DaffCartAddressFactory);
     paymentFactory = TestBed.inject(DaffCartPaymentFactory);
-    shippingMethodFactory = TestBed.inject(DaffCartShippingRateFactory);
 
     orderId = 'id';
     error = {
@@ -175,8 +172,8 @@ describe('Cart | Selector | Cart', () => {
       shipping_address: cartAddressFactory.create(),
       billing_address: cartAddressFactory.create(),
       payment: paymentFactory.create(),
-      shipping_information: shippingMethodFactory.create(),
     });
+    cart.shipping_information.address_id = String(cart.shipping_address.id);
     loading = {
       [DaffCartOperationType.Cart]: DaffState.Complete,
       [DaffCartOperationType.Item]: DaffState.Complete,

libs/cart/testing/src/factories/cart-shipping-information.factory.spec.ts

@@ -0,0 +1,47 @@
+import { TestBed } from '@angular/core/testing';
+
+import { DaffCartShippingRate } from '@daffodil/cart';
+
+import { DaffCartShippingRateFactory } from './cart-shipping-rate.factory';
+
+describe('Cart | Testing | Factories | CartShippingRateFactory', () => {
+
+  let cartShippingRateFactory: DaffCartShippingRateFactory;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      providers: [DaffCartShippingRateFactory],
+    });
+
+    cartShippingRateFactory = TestBed.inject(DaffCartShippingRateFactory);
+  });
+
+  it('should be created', () => {
+    expect(cartShippingRateFactory).toBeTruthy();
+  });
+
+  describe('create', () => {
+
+    let result: DaffCartShippingRate;
+
+    beforeEach(() => {
+      result = cartShippingRateFactory.create();
+    });
+
+    xit('should return a CartShippingRate with all required fields defined', () => {
+
+    });
+  });
+
+  describe('createMany', () => {
+    let result: DaffCartShippingRate[];
+
+    it('should create as many cart shipping rates as desired', () => {
+      result = cartShippingRateFactory.createMany(2);
+      expect(result.length).toEqual(2);
+
+      result = cartShippingRateFactory.createMany(3);
+      expect(result.length).toEqual(3);
+    });
+  });
+});

libs/cart/testing/src/factories/cart-shipping-information.factory.ts

@@ -0,0 +1,20 @@
+import { Injectable } from '@angular/core';
+import { faker } from '@faker-js/faker/locale/en_US';
+
+import { DaffCartShippingInformation } from '@daffodil/cart';
+import { DaffModelFactory } from '@daffodil/core/testing';
+
+import { MockCartShippingRate } from './cart-shipping-rate.factory';
+
+export class MockCartShippingInformation extends MockCartShippingRate implements DaffCartShippingInformation {
+  address_id = faker.datatype.uuid();
+}
+
+@Injectable({
+  providedIn: 'root',
+})
+export class DaffCartShippingInformationFactory extends DaffModelFactory<DaffCartShippingInformation>{
+  constructor(){
+    super(MockCartShippingInformation);
+  }
+}

libs/cart/testing/src/factories/cart-shipping-rate.factory.spec.ts

@@ -1,46 +1,46 @@
 import { TestBed } from '@angular/core/testing';
 
-import { DaffCartShippingRate } from '@daffodil/cart';
+import { DaffCartShippingInformation } from '@daffodil/cart';
 
-import { DaffCartShippingRateFactory } from './cart-shipping-rate.factory';
+import { DaffCartShippingInformationFactory } from './cart-shipping-information.factory';
 
-describe('Cart | Testing | Factories | CartShippingRateFactory', () => {
+describe('@daffodil/cart/testing | DaffCartShippingInformationFactory', () => {
 
-  let cartShippingRateFactory: DaffCartShippingRateFactory;
+  let cartShippingInformationFactory: DaffCartShippingInformationFactory;
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      providers: [DaffCartShippingRateFactory],
+      providers: [DaffCartShippingInformationFactory],
     });
 
-    cartShippingRateFactory = TestBed.inject(DaffCartShippingRateFactory);
+    cartShippingInformationFactory = TestBed.inject(DaffCartShippingInformationFactory);
   });
 
   it('should be created', () => {
-    expect(cartShippingRateFactory).toBeTruthy();
+    expect(cartShippingInformationFactory).toBeTruthy();
   });
 
   describe('create', () => {
 
-    let result: DaffCartShippingRate;
+    let result: DaffCartShippingInformation;
 
     beforeEach(() => {
-      result = cartShippingRateFactory.create();
+      result = cartShippingInformationFactory.create();
     });
 
-    xit('should return a CartShippingRate with all required fields defined', () => {
+    xit('should return a CartShippingInformation with all required fields defined', () => {
 
     });
   });
 
   describe('createMany', () => {
-    let result: DaffCartShippingRate[];
+    let result: DaffCartShippingInformation[];
 
     it('should create as many cart shipping rates as desired', () => {
-      result = cartShippingRateFactory.createMany(2);
+      result = cartShippingInformationFactory.createMany(2);
       expect(result.length).toEqual(2);
 
-      result = cartShippingRateFactory.createMany(3);
+      result = cartShippingInformationFactory.createMany(3);
       expect(result.length).toEqual(3);
     });
   });

libs/cart/testing/src/factories/cart.factory.ts

@@ -4,6 +4,7 @@ import { faker } from '@faker-js/faker/locale/en_US';
 import { DaffCart } from '@daffodil/cart';
 import { DaffModelFactory } from '@daffodil/core/testing';
 
+import { DaffCartShippingInformationFactory } from './cart-shipping-information.factory';
 import { DaffCartTotalFactory } from './cart-total.factory';
 
 export class MockCart implements DaffCart {
@@ -14,15 +15,16 @@ export class MockCart implements DaffCart {
   items = [];
   billing_address = null;
   shipping_address = null;
-  shipping_information = null;
+  shipping_information = this.shippingInformationFactory.create();
   totals = this.totalFactory.createAllTotals();
   payment = null;
   available_shipping_methods = [];
   available_payment_methods = [];
   extra_attributes = {};
 
   constructor(
-    private totalFactory: DaffCartTotalFactory,
+    protected totalFactory: DaffCartTotalFactory,
+    protected shippingInformationFactory: DaffCartShippingInformationFactory,
   ) {}
 };
 
@@ -32,7 +34,8 @@ export class MockCart implements DaffCart {
 export class DaffCartFactory extends DaffModelFactory<DaffCart>{
   constructor(
     totalFactory: DaffCartTotalFactory,
+    shippingInformationFactory: DaffCartShippingInformationFactory,
   ) {
-    super(MockCart, totalFactory);
+    super(MockCart, totalFactory, shippingInformationFactory);
   }
 }

libs/cart/testing/src/factories/public_api.ts

@@ -5,5 +5,6 @@ export * from './cart-item/composite-cart-item.factory';
 export * from './cart-address.factory';
 export * from './cart-payment.factory';
 export * from './cart-shipping-rate.factory';
+export * from './cart-shipping-information.factory';
 export * from './cart-coupon.factory';
 export * from './cart-total.factory';