Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): add input component #3381

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat(design): add input component #3381

wants to merge 9 commits into from

Conversation

gracetxgao
Copy link
Contributor

@gracetxgao gracetxgao commented Dec 27, 2024 •
edited by xelaint
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #416
Fixes: #3407

What is the new behavior?

Adds input component.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@gracetxgao gracetxgao requested a review from a team as a code owner December 27, 2024 21:59
@gracetxgao gracetxgao mentioned this pull request Dec 27, 2024
Open
3 tasks
xelaint
xelaint reviewed Jan 2, 2025
View reviewed changes
libs/design/src/atoms/form/form-field/form-field/form-field.component.html Outdated
</div>
<ng-content select="daff-error-message"></ng-content>
@if (_control?.ngControl?.touched) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damienwebdev is it up to the form field component to enforce this?

@xelaint xelaint requested a review from damienwebdev January 8, 2025 20:17
@xelaint xelaint added package: design @daffodil/design status: awaiting review This PR is awaiting review labels Jan 8, 2025
@xelaint xelaint mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xelaint xelaint xelaint requested changes

@damienwebdev damienwebdev Awaiting requested review from damienwebdev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: design @daffodil/design status: awaiting review This PR is awaiting review
Projects
None yet
Milestone
No milestone
2 participants
@gracetxgao @xelaint