fix tests

graycoreio · Jan 8, 2025 · 180dbf1 · 180dbf1
1 parent 9fb2502
commit 180dbf1
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 24 deletions.
diff --git a/libs/design/src/atoms/form/form-field/form-field/form-field.component.spec.ts b/libs/design/src/atoms/form/form-field/form-field/form-field.component.spec.ts
@@ -19,12 +19,11 @@ import { DaffFormFieldControl } from '../form-field-control';
 import { DaffFormFieldMissingControlMessage } from '../form-field-errors';
 
 @Component({ template: `
-  <daff-form-field [formSubmitted]="formSubmittedValue">
+  <daff-form-field>
     <input daff-input [formControl]="formControl">
     <daff-error-message></daff-error-message>
   </daff-form-field>` })
 class WrapperComponent {
-  formSubmittedValue: boolean;
   formControl = new UntypedFormControl('', Validators.required);
 }
 
@@ -118,13 +117,12 @@ describe('@daffodil/design | DaffFormFieldComponent | Usage', () => {
 });
 
 @Component({ template: `
-  <daff-form-field [formSubmitted]="formSubmittedValue">
+  <daff-form-field>
     <daff-error-message></daff-error-message>
   </daff-form-field>` })
 
-class WrapperWithoutControlComponent {
-  formSubmittedValue: boolean;
-}
+class WrapperWithoutControlComponent {}
+
 describe('@daffodil/design | DaffFormFieldComponent | Usage Without Control', () => {
   let fixture: ComponentFixture<WrapperWithoutControlComponent>;
 

diff --git a/libs/design/src/atoms/form/hint/hint.component.spec.ts b/libs/design/src/atoms/form/hint/hint.component.spec.ts
@@ -1,31 +1,54 @@
+import {
+  Component,
+  DebugElement,
+} from '@angular/core';
 import {
   waitForAsync,
   ComponentFixture,
   TestBed,
 } from '@angular/core/testing';
+import { By } from '@angular/platform-browser';
 
 import { DaffHintComponent } from './hint.component';
 
+@Component({
+  template: `<daff-hint>Hint</daff-hint>`,
+  standalone: true,
+  imports: [
+    DaffHintComponent,
+  ],
+})
+
+class WrapperComponent {}
+
 describe('@daffodil/design | DaffHintComponent', () => {
-  let fixture: ComponentFixture<DaffHintComponent>;
-  let component: DaffHintComponent;
+  let wrapper: WrapperComponent;
+  let de: DebugElement;
+  let fixture: ComponentFixture<WrapperComponent>;
 
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
-      declarations: [
-        DaffHintComponent,
+      imports: [
+        WrapperComponent,
       ],
     })
       .compileComponents();
   }));
 
   beforeEach(() => {
-    fixture = TestBed.createComponent(DaffHintComponent);
-    component = fixture.componentInstance;
+    fixture = TestBed.createComponent(WrapperComponent);
+    wrapper = fixture.componentInstance;
+    de = fixture.debugElement.query(By.css('daff-hint'));
     fixture.detectChanges();
   });
 
   it('should create', () => {
-    expect(component).toBeTruthy();
+    expect(wrapper).toBeTruthy();
+  });
+
+  it('should add a class of "daff-hint" to the host element', () => {
+    expect(de.classes).toEqual(jasmine.objectContaining({
+      'daff-hint': true,
+    }));
   });
 });
diff --git a/libs/design/src/atoms/form/input/input.component.spec.ts b/libs/design/src/atoms/form/input/input.component.spec.ts
@@ -13,17 +13,14 @@ import { By } from '@angular/platform-browser';
 import { DaffInputComponent } from './input.component';
 
 @Component({
-  template: `<input daff-input [formSubmitted]="formSubmittedValue">`,
+  template: `<input daff-input>`,
 })
-class WrapperComponent {
-  formSubmittedValue: boolean;
-}
+class WrapperComponent {}
 
 describe('@daffodil/design | DaffInputComponent', () => {
   let wrapper: WrapperComponent;
   let fixture: ComponentFixture<WrapperComponent>;
   let stubFormControl;
-  let stubFormSubmitted: boolean;
   let component: DaffInputComponent;
   let componentDE: DebugElement;
 
@@ -39,11 +36,9 @@ describe('@daffodil/design | DaffInputComponent', () => {
 
   beforeEach(() => {
     stubFormControl = new UntypedFormControl();
-    stubFormSubmitted = false;
 
     fixture = TestBed.createComponent(WrapperComponent);
     wrapper = fixture.componentInstance;
-    wrapper.formSubmittedValue = stubFormSubmitted;
     fixture.detectChanges();
 
     componentDE = fixture.debugElement.query(By.css('[daff-input]'));
@@ -54,10 +49,6 @@ describe('@daffodil/design | DaffInputComponent', () => {
     expect(wrapper).toBeTruthy();
   });
 
-  it('should be able to take formSubmitted as input', () => {
-    expect(component.formSubmitted).toEqual(stubFormSubmitted);
-  });
-
   describe('onFocus', () => {
     it('should call focus on the native element', () => {
       spyOn(componentDE.nativeElement, 'focus');