Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] DaffFormFieldComponent refactor #3407

Open
Tracked by #416
xelaint opened this issue Jan 9, 2025 · 0 comments · May be fixed by #3381
Open
Tracked by #416

[FEAT] DaffFormFieldComponent refactor #3407

xelaint opened this issue Jan 9, 2025 · 0 comments · May be fixed by #3381
Assignees
Labels
package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Jan 9, 2025

💡 Feature request

Feature Name

Update form field implementation

The Desired Behavior

https://www.figma.com/design/4A0SIso9uJ7HGKdW9GKMGr/Daffodil-Design-System?node-id=664-12082

  • Form field should support native select, custom select, native input, custom input, textarea, quantity field, and quantity select.
  • Input types to support:
<input type="date">
<input type="datetime-local">
<input type="email">
<input type="month">
<input type="number">
<input type="password">
<input type="search">
<input type="tel">
<input type="text">
<input type="time">
<input type="url">
<input type="week">
  • Manage disabled, focus, mutating, error, hints, and skeleton (loading) states.

The template API of daff-form-field should look something like:

<form>
  <daff-form-field>
    <label for="grace">Name</label>
    <input type="text" id="grace" placeholder="Test"/>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <daff-form-field>
    <label for="grace">Name</label>
    <select>
   	<option></option>
    </select>
    <div class="select-arrow">:down_arrow:</div>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <daff-form-field>
    <label for="grace">Name</label>
    <textarea id="grace"></textarea>
    <div class="select-arrow">:down_arrow:</div>
    <div class="error">Error message goes here.</div>
  </daff-form-field>

  <button type="submit">Submit</button>
</form>

Your Use Case

As a user, I should be able to fill out fields in a form.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 9, 2025
@xelaint xelaint changed the title DaffFormFieldComponent refactor [FEAT] DaffFormFieldComponent refactor Jan 9, 2025
@xelaint xelaint added the package: design @daffodil/design label Jan 9, 2025
@xelaint xelaint added the feat a new feature, enhancement, or improvement label Jan 9, 2025
@xelaint xelaint linked a pull request Jan 9, 2025 that will close this issue
3 tasks
@xelaint xelaint removed the feat a new feature, enhancement, or improvement label Jan 17, 2025
@damienwebdev damienwebdev removed their assignment Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants