-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy full ESM with "type": "module" in "latest-esm" npm tag #3361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add integrationTests/esm
for this package.
Try to test as many esm-specific things as possible.
Also please ensure that this package works with upcoming TS 4.5 that should support esm natively and add integration tests for that. |
1f2d271
to
48cfc07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
looks like esm tag makes sense out of band from canaries and all that
@IvanGoncharov is this ready for re-review? |
Motivation: allow to reuse more stuff from 'resources/utils.ts' Working on rebasing graphql#3361 that adds even more code into integrationTests so want to keep it simple by reusing code from 'utils.ts'
Motivation: allow to reuse more stuff from 'resources/utils.ts' Working on rebasing graphql#3361 that adds even more code into integrationTests so want to keep it simple by reusing code from 'utils.ts'
1a74a91
to
b806b6f
Compare
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
b806b6f
to
7d134d6
Compare
7d134d6
to
18f15ce
Compare
This comment has been minimized.
This comment has been minimized.
@IvanGoncharov The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
I rebased this PR to the latest main as the solution for #3603 |
@IvanGoncharov @PabloSzx et al question about the current state => the build scripts add a build qualifier of "+esm" and a tag suffix of "-esm", but do not rename the package to Over at the So, where are we with this? Some options: (1) we can get rid of the build qualifiers and tag suffix, and have a package name suffix of "-esm" and every time we publish to So either way, the end goal will be to get rid of the build qualifier and tag suffix, right? But have we decided on what will happen? |
I also just re-published [email protected] as [email protected] https://npm.im/graphql-esm, tested it in an example project using libraries with full ESM support https://github.com/PabloSzx/test-graphql-esm, everything works perfectly 👌
It can be tested right now doing this: