fix vitest incompatibility

[capaj]

ATM vitest/vite cannot load graphql correctly. It always ends up loading both CJS and ESM source in my projects.
I have reported this to vite here: vitejs/vite#7879
but I think a simple change here could resolve the problem. I think using "module" entry point is obsolete/deprecated with node.js.

I have tested this change with latest vitests and it seems to work correctly with this change. I will be using patch-package with graphql 16 for now, but it would be nice if this could land.

Also why was private: true set here?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: capaj / name: Jiri Spac (4412cd8)

[n1ru4l]

@capaj Even on Node.js if you load graphql in an ESM context it will load the common.js version because the published package does not have an exports map 🤷‍♂️ (See this code-sandbox: https://codesandbox.io/s/graphql-module-resolution-on-node-js-issue-xk5w8t?file=/index.js:0-398). "module": "index.mjs", is completely ignored by Node.js 😁.

This is the published package.json: https://unpkg.com/[email protected]/package.json

Also why was private: true set here?

Because the npm package is built in a custom way:
https://github.com/graphql/graphql-js/blob/main/resources/build-npm.ts

---

A list of related issues/prs:

• Provide a clear path on how to support graphql-js 16 and 17 at the same time as a esm and cjs library author #3603
• Cannot use ESM together with CJS -> cannot use "import" with graphql-express #2740
• ESM named exports are not available with "type": "module" #2721
• deploy full ESM with "type": "module" in "latest-esm" npm tag #3361
• Fully switch to ESM (scripts, tests, etc.) #3564
• feat: replace instanceOf with unique Symbol checks #3617
• add exports field to support Node.js ESM #3217

[capaj]

I'll revert that change with private then, thanks @n1ru4l

[n1ru4l]

I also think your PR on v16 will not be accepted because adding an exports map breaks all the people that do "deep imports" today, thus it is considered a breaking change. 😁

Another fun fact is that graphql-js does not work on CodeSandbox frontend templates since v15 was released.

[capaj]

Sounds about right. It would be best to just revert back to pure CJS without introducing and exports map.

[capaj]

I should have checked your links before responding :D
I will just use https://npm.im/graphql-esm from #3361

seems like it is an official package-might be worth adding to the docs.
Let's close this one, hopefully @PabloSzx has got it