Ensure Grails plugin `assemble` task produces a JAR artifact #369

matrei · 2024-12-11T09:39:58Z

Previously, running the assemble task in a Grails plugin project only generated *.war and *-plain.war artifacts. This change ensures that the task also produces the expected JAR artifact, aligning with typical plugin packaging needs.

Previously, running the `assemble` task in a Grails plugin project only generated `*.war` and `*-plain.war` artifacts. This change ensures that the task also produces the expected JAR artifact, aligning with typical plugin packaging needs.

matrei · 2024-12-11T09:41:31Z

grails/grails-forge#457

codeconsole · 2024-12-12T19:51:09Z

exclude logback-spring.xml as well?

matrei · 2024-12-12T20:22:31Z

exclude logback-spring.xml as well?

@codeconsole logback-spring.xml wasn't introduced until 7.0.x. I had planned to exclude it after this is merged up.

codeconsole

Will the tasks bootWar, bootDistZip, bootDistTar, bootStartScripts, distZip, distTar still continue to run? if so, should they be disabled as well?

why generate a war and a war-plain? should that be disabled as well?

Probably best in tbe end, bootRun should work and assemble should just produce 1 jar.

davydotcom · 2024-12-14T11:22:32Z

Just confirming we aren't breaking non jar packaging. I use wars on tomcat and not the self contained jar for example

matrei · 2024-12-14T13:05:36Z

@codeconsole @davydotcom This is the current behavior. Is this what you would expect from assemble in a plugin project?

PS C:\Users\matti\test\g622plugin> ./gradlew assemble --console=plain                                                                                                               
> Task :compileAstJava NO-SOURCE                                                                                                                                                    
> Task :compileAstGroovy NO-SOURCE
> Task :processAstResources NO-SOURCE
> Task :astClasses UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :configScript
> Task :compileGroovy FROM-CACHE
> Task :copyAstClasses NO-SOURCE
> Task :assetPluginPackage FROM-CACHE
> Task :buildProperties
> Task :copyCommands NO-SOURCE
> Task :copyTemplates NO-SOURCE
> Task :processResources
> Task :classes
> Task :bootWarMainClassName
> Task :compileWebappGroovyPages NO-SOURCE
> Task :compileGroovyPages
> Task :bootWar
> Task :bootStartScripts
> Task :bootDistTar
> Task :bootDistZip
> Task :jar
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :war
> Task :assemble

BUILD SUCCESSFUL in 14s
16 actionable tasks: 14 executed, 2 from cache
PS C:\Users\matti\test\g622plugin> dir build/libs


    Directory: C:\Users\matti\test\g622plugin\build\libs


Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        2024-12-14     14:00       66098817 g622plugin-0.1-plain.war
-a----        2024-12-14     14:00        1070159 g622plugin-0.1.jar
-a----        2024-12-14     14:00       73550518 g622plugin-0.1.war

codeconsole · 2024-12-14T13:06:40Z

Just confirming we aren't breaking non jar packaging. I use wars on tomcat and not the self contained jar for example

@davydotcom this is just for grails plugins. You run a plugin from a war file?

codeconsole · 2024-12-14T13:10:42Z

@matrei so why is g622plugin-0.1-plain.war needed? what would that be used for?

codeconsole · 2024-12-14T13:19:16Z

This is all that is needed for bootRun:

> Task :compileAstJava NO-SOURCE
> Task :compileAstGroovy NO-SOURCE
> Task :processAstResources NO-SOURCE
> Task :astClasses UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :configScript
> Task :compileGroovy
> Task :copyAstClasses NO-SOURCE
> Task :generateGitProperties FROM-CACHE
> Task :assetPluginPackage FROM-CACHE
> Task :buildProperties
> Task :copyCommands NO-SOURCE
> Task :copyTemplates NO-SOURCE
> Task :processResources
> Task :classes
> Task :compileWebappGroovyPages
> Task :compileGroovyPages
> Task :jar
`
> Task :resolveMainClassName

> Task :bootRun

@matrei Why do we need these to build a plugin?

> Task :bootWar
> Task :bootStartScripts
> Task :bootDistTar
> Task :bootDistZip
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :war

matrei · 2024-12-14T13:21:01Z

so why is g622plugin-0.1-plain.war needed? what would that be used for?

I don't know. Should I disable the bootWar and war tasks as well?

codeconsole · 2024-12-14T13:36:10Z

@matrei I would disable ALL of these:

> Task :bootWar
> Task :bootStartScripts
> Task :bootDistTar
> Task :bootDistZip
> Task :startScripts
> Task :distTar
> Task :distZip
> Task :war

codeconsole · 2024-12-14T13:44:27Z

BTW, bootRun is currently failing for freshly created 6.2.2 plugins:

% grails create-plugin g622plugin
| Application created at ~/Documents/workspace/grails/g622plugin
% cd g622plugin                  
%  ./gradlew bootRun --console=plain
Starting a Gradle Daemon, 1 busy Daemon could not be reused, use --status for details
> Task :compileAstJava NO-SOURCE
> Task :compileAstGroovy NO-SOURCE
> Task :processAstResources NO-SOURCE
> Task :astClasses UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :configScript
> Task :compileGroovy
> Task :copyAstClasses NO-SOURCE
> Task :copyCommands NO-SOURCE
> Task :copyTemplates NO-SOURCE
> Task :processResources
> Task :classes
> Task :bootRunMainClassName

> Task :bootRun FAILED
2024-12-14 06:41:49.335 ERROR --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   : 

***************************
APPLICATION FAILED TO START
***************************

Description:

Web application could not be started as there was no org.springframework.boot.web.servlet.server.ServletWebServerFactory bean defined in the context.

Action:

Check your application's dependencies for a supported servlet web server.
Check the configured web application type.


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':bootRun'.
> Process 'command '~/.sdkman/candidates/java/17.0.13-librca/bin/java'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1m 22s
5 actionable tasks: 5 executed

matrei · 2024-12-14T14:39:55Z

BTW, bootRun is currently failing for freshly created 6.2.2 plugins:

I think you have to do: grails create-web-plugin

mattias@mattias-xps:~/test$ grails -V
Grails Version: 6.2.2
JVM Version: 11.0.20
mattias@mattias-xps:~/test$ grails create-web-plugin g622plugin
| Application created at /home/mattias/test/g622plugin
mattias@mattias-xps:~/test$ cd g622plugin
mattias@mattias-xps:~/test/g622plugin$ ./gradlew bootRun --console=plain
> Task :compileAstJava NO-SOURCE
> Task :compileAstGroovy NO-SOURCE
> Task :processAstResources NO-SOURCE
> Task :astClasses UP-TO-DATE
> Task :compileJava NO-SOURCE
> Task :configScript
> Task :compileGroovy
> Task :copyAstClasses NO-SOURCE
> Task :assetPluginPackage
> Task :buildProperties
> Task :copyCommands NO-SOURCE
> Task :copyTemplates NO-SOURCE
> Task :processResources
> Task :classes
> Task :bootRunMainClassName

> Task :bootRun
Grails application running at http://localhost:8080 in environment: development

codeconsole · 2024-12-14T16:36:34Z

I think you have to do: grails create-web-plugin

interesting. didn't pre-forge just be create-plugin ?

are the following dependencies expected for a non web plugin?

    profile "org.grails.profiles:web"
    implementation "org.grails:grails-plugin-interceptors"
    implementation "org.grails:grails-plugin-rest"
    implementation "org.grails:grails-plugin-url-mappings"
    implementation "org.grails:grails-web-boot"
    implementation "org.grails.plugins:gsp"

I created a new issue for that, let's limit this PR to disabling bootWar, bootStartScripts, bootDistTar, bootDistZip, startScripts, distTar, distZip, war as well

matrei added 2 commits December 11, 2024 10:30

refactor: name task configuration closure parameters for clarity

3cb7bcc

matrei requested review from codeconsole, jdaugherty and jamesfredley December 11, 2024 09:42

sbglasius approved these changes Dec 11, 2024

View reviewed changes

jdaugherty approved these changes Dec 11, 2024

View reviewed changes

jamesfredley approved these changes Dec 11, 2024

View reviewed changes

matrei mentioned this pull request Dec 12, 2024

Forge create-plugin creates with a plugin -plain artifacts and also a war grails/grails-forge#457

Open

codeconsole approved these changes Dec 14, 2024

View reviewed changes

codeconsole self-requested a review December 14, 2024 07:46

codeconsole requested changes Dec 14, 2024

View reviewed changes

codeconsole mentioned this pull request Dec 14, 2024

create-plugin should not include web dependencies grails/grails-forge#464

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure Grails plugin `assemble` task produces a JAR artifact #369

Ensure Grails plugin `assemble` task produces a JAR artifact #369

matrei commented Dec 11, 2024

matrei commented Dec 11, 2024

codeconsole commented Dec 12, 2024 •

edited

Loading

matrei commented Dec 12, 2024

codeconsole left a comment •

edited

Loading

davydotcom commented Dec 14, 2024

matrei commented Dec 14, 2024 •

edited

Loading

codeconsole commented Dec 14, 2024 •

edited

Loading

codeconsole commented Dec 14, 2024

codeconsole commented Dec 14, 2024 •

edited

Loading

matrei commented Dec 14, 2024

codeconsole commented Dec 14, 2024

codeconsole commented Dec 14, 2024

matrei commented Dec 14, 2024

codeconsole commented Dec 14, 2024 •

edited

Loading

Ensure Grails plugin assemble task produces a JAR artifact #369

Are you sure you want to change the base?

Ensure Grails plugin assemble task produces a JAR artifact #369

Conversation

matrei commented Dec 11, 2024

matrei commented Dec 11, 2024

codeconsole commented Dec 12, 2024 • edited Loading

matrei commented Dec 12, 2024

codeconsole left a comment • edited Loading

Choose a reason for hiding this comment

davydotcom commented Dec 14, 2024

matrei commented Dec 14, 2024 • edited Loading

codeconsole commented Dec 14, 2024 • edited Loading

codeconsole commented Dec 14, 2024

codeconsole commented Dec 14, 2024 • edited Loading

matrei commented Dec 14, 2024

codeconsole commented Dec 14, 2024

codeconsole commented Dec 14, 2024

matrei commented Dec 14, 2024

codeconsole commented Dec 14, 2024 • edited Loading

Ensure Grails plugin `assemble` task produces a JAR artifact #369

Ensure Grails plugin `assemble` task produces a JAR artifact #369

codeconsole commented Dec 12, 2024 •

edited

Loading

codeconsole left a comment •

edited

Loading

matrei commented Dec 14, 2024 •

edited

Loading

codeconsole commented Dec 14, 2024 •

edited

Loading

codeconsole commented Dec 14, 2024 •

edited

Loading

codeconsole commented Dec 14, 2024 •

edited

Loading