Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge create-plugin creates with a plugin -plain artifacts and also a war #457

Open
codeconsole opened this issue Dec 10, 2024 · 5 comments
Assignees

Comments

@codeconsole
Copy link
Contributor

git clone --branch 7.0.x --single-branch https://github.com/grails/grails-forge.git
sdk env
./gradlew assemble
unzip ./grails-cli/build/distributions/grails-cli-7.0.0-SNAPSHOT -d cli
./cli/grails-cli-7.0.0-SNAPSHOT/bin/grails create-plugin com.example.myplugin
cd myplugin 
touch settings.gradle
./gradlew assemble
ls -lah build/libs 
total 270712
drwxr-xr-x  user  staff   128B Dec 10 14:24 .
drwxr-xr-x  9 user  staff   288B Dec 10 14:24 ..
-rw-r--r--  1 user  staff    62M Dec 10 14:24 myplugin-0.1-plain.war
-rw-r--r--  1 user  staff    70M Dec 10 14:24 myplugin-0.1.war
@codeconsole codeconsole changed the title Forget creates plugins with -plain artifacts and also a war Forge create-plugin creates with -plain artifacts and also a war Dec 10, 2024
@codeconsole codeconsole changed the title Forge create-plugin creates with -plain artifacts and also a war Forge create-plugin creates with a plugin -plain artifacts and also a war Dec 10, 2024
@codeconsole
Copy link
Contributor Author

@matrei didn't you resolve the -plain thing?

@jdaugherty
Copy link
Contributor

@codeconsole
Copy link
Contributor Author

gradle clean jar produces build/libs/demo-0.1-plain.jar

@matrei
Copy link
Contributor

matrei commented Dec 11, 2024

There are two issues here.

  1. The -plain suffix removal is only invoked when using org.grails.grails-plugin (which I think is correct).

gradle clean jar produces build/libs/demo-0.1-plain.jar

Is this a plugin project?

  1. assemble does currently not invoke the jar task in org.grails.grails-plugin (which I think should be fixed).

@matrei
Copy link
Contributor

matrei commented Dec 12, 2024

@codeconsole Do you have any comments on grails/grails-gradle-plugin#369 before I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants