Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix SlackAction: change SlackAction "value" to "url" #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix SlackAction: change SlackAction "value" to "url" #43

wants to merge 5 commits into from

Commits on Jun 13, 2018

  1. Remove dead code

    @dvehar
    dvehar committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    b56be76 View commit details
    Browse the repository at this point in the history

  2. Change SlackAction "value" to "url" 

    Using "value" does not work (maybe it used to). [Example](https://api.slack.com/docs/messages/builder?msg=%7B%22text%22%3A%22%3C%40W1A2BC3DD%3E%20approved%20your%20travel%20request.%20Book%20any%20airline%20you%20like%20by%20continuing%20below.%22%2C%22channel%22%3A%22C061EG9SL%22%2C%22attachments%22%3A%5B%7B%22fallback%22%3A%22Book%20your%20flights%20at%20https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%2C%22actions%22%3A%5B%7B%22type%22%3A%22button%22%2C%22text%22%3A%22Book%20flights%20%F0%9F%9B%AB%22%2C%22value%22%3A%22https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%7D%5D%7D%5D%7D)

Using "url" does work. [Example](https://api.slack.com/docs/messages/builder?msg=%7B%22text%22%3A%22%3C%40W1A2BC3DD%3E%20approved%20your%20travel%20request.%20Book%20any%20airline%20you%20like%20by%20continuing%20below.%22%2C%22channel%22%3A%22C061EG9SL%22%2C%22attachments%22%3A%5B%7B%22fallback%22%3A%22Book%20your%20flights%20at%20https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%2C%22actions%22%3A%5B%7B%22type%22%3A%22button%22%2C%22text%22%3A%22Book%20flights%20%F0%9F%9B%AB%22%2C%22url%22%3A%22https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%7D%5D%7D%5D%7D)
    @dvehar
    dvehar committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    dcc34fe View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2018

  1. Refactor SlackAction to use an object oriented approach for each type… 

    … of action

Creates the concrete SlackActions:
- BasicButtonSlackAction
- InteractiveButtonSlackAction
- InteractiveSelectSlackAction

Adds tests
    @dvehar
    dvehar committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    cc66b37 View commit details
    Browse the repository at this point in the history

  2. BasicButtonSlackAction should extend ButtonSlackAction

    @dvehar
    dvehar committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    3ef17a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. make style public

    @dvehar
    dvehar committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    2594aa6 View commit details
    Browse the repository at this point in the history