Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Fix SlackAction: change SlackAction "value" to "url" #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix SlackAction: change SlackAction "value" to "url" #43

wants to merge 5 commits into from

Conversation

dvehar
Copy link

@dvehar dvehar commented Jun 13, 2018

Using "value" does not work (maybe it used to). Example

Using "url" does work. Example

@dvehar
Remove dead code
b56be76
@dvehar
Change SlackAction "value" to "url"
dcc34fe 
Using "value" does not work (maybe it used to). [Example](https://api.slack.com/docs/messages/builder?msg=%7B%22text%22%3A%22%3C%40W1A2BC3DD%3E%20approved%20your%20travel%20request.%20Book%20any%20airline%20you%20like%20by%20continuing%20below.%22%2C%22channel%22%3A%22C061EG9SL%22%2C%22attachments%22%3A%5B%7B%22fallback%22%3A%22Book%20your%20flights%20at%20https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%2C%22actions%22%3A%5B%7B%22type%22%3A%22button%22%2C%22text%22%3A%22Book%20flights%20%F0%9F%9B%AB%22%2C%22value%22%3A%22https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%7D%5D%7D%5D%7D)

Using "url" does work. [Example](https://api.slack.com/docs/messages/builder?msg=%7B%22text%22%3A%22%3C%40W1A2BC3DD%3E%20approved%20your%20travel%20request.%20Book%20any%20airline%20you%20like%20by%20continuing%20below.%22%2C%22channel%22%3A%22C061EG9SL%22%2C%22attachments%22%3A%5B%7B%22fallback%22%3A%22Book%20your%20flights%20at%20https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%2C%22actions%22%3A%5B%7B%22type%22%3A%22button%22%2C%22text%22%3A%22Book%20flights%20%F0%9F%9B%AB%22%2C%22url%22%3A%22https%3A%2F%2Fflights.example.com%2Fbook%2Fr123456%22%7D%5D%7D%5D%7D)
@dvehar
Copy link
Author

dvehar commented Jun 13, 2018

@gpedro @galimru please review

@rgalimov
Copy link

rgalimov commented Jun 19, 2018 •
edited
Loading

Hi @dvehar, the value is needed for interactive message buttons as response value to help determine which button was pressed. When you use url field it will create link button like described here https://api.slack.com/docs/message-attachments#link_buttons
I think it would be better to add url field and leave other fields as is.

@dvehar
Refactor SlackAction to use an object oriented approach for each type…
cc66b37 
… of action

Creates the concrete SlackActions:
- BasicButtonSlackAction
- InteractiveButtonSlackAction
- InteractiveSelectSlackAction

Adds tests
@dvehar
Copy link
Author

dvehar commented Jun 22, 2018

@rgalimov I pushed some changes. I broke out the SlackAction functionality into specific subclasses (BasicButtonSlackAction, InteractiveButtonSlackAction, InteractiveSelectSlackAction) and added tests.

@dvehar
Copy link
Author

dvehar commented Jul 13, 2018

@rgalimov can you please review?

@galimru
Copy link
Contributor

galimru commented Jul 13, 2018

@dvehar this looks fine

@dvehar
Copy link
Author

dvehar commented Jul 13, 2018

@gpedro please review / merge.

@dvehar
Copy link
Author

dvehar commented Jul 21, 2018

@gpedro just following up. Can this change be merged?

@deepakputhraya
Copy link

@gpedro @galimru Can these changes be merged?

@dvehar
Copy link
Author

dvehar commented Feb 4, 2019

@gpedro @jaypatel512 @rgalimov are you able to merge?

@rgalimov
Copy link

rgalimov commented Feb 4, 2019

@dvehar Sorry, I don't have access to merge PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaypatel512 jaypatel512 jaypatel512 approved these changes

@agentgonzo agentgonzo agentgonzo approved these changes

@rgalimov rgalimov rgalimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dvehar @rgalimov @galimru @deepakputhraya @jaypatel512 @agentgonzo