Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[background image] Make image data participate in copy/paste #1795

Merged
merged 19 commits into from
Nov 16, 2024
Merged

[background image] Make image data participate in copy/paste #1795

merged 19 commits into from
Nov 16, 2024

Commits on Nov 16, 2024

  1. Add backgroundImageData arg to _writeLayersToClipboard

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    655a1ff View commit details
    Browse the repository at this point in the history

  2. Factor out object construction from serialization

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    cc54bdf View commit details
    Browse the repository at this point in the history

  3. If there's bg image data, add it to the json object

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    d35afed View commit details
    Browse the repository at this point in the history

  4. Add bg image data for varGlyph copy; add stubs for other cases

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    87c62cd View commit details
    Browse the repository at this point in the history

  5. Add image data for layer glyph copy

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    978e001 View commit details
    Browse the repository at this point in the history

  6. Make support for bg images detectable

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    96245d7 View commit details
    Browse the repository at this point in the history

  7. Make new imageIdentifiers for bg images when pasting

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b9e4b13 View commit details
    Browse the repository at this point in the history

  8. Add FontHandler.putBackgroundImage()

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    2f40c24 View commit details
    Browse the repository at this point in the history

  9. Refactor so we can also add stuff to the cache from the clipboard, etc.

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    fe097d8 View commit details
    Browse the repository at this point in the history

  10. Fix remote method signature

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    57cce12 View commit details
    Browse the repository at this point in the history

  11. Fix caching approach; implement writing bg image data

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    c40e84b View commit details
    Browse the repository at this point in the history

  12. Write pasted bg images, and make sure they have unique identifiers

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    cb63c6b View commit details
    Browse the repository at this point in the history

  13. Rename method; ensure the imagePromise gets resolved even when the im… 

    …age data can't be loaded
    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    c8166ca View commit details
    Browse the repository at this point in the history

  14. Add null image

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    19ecb8c View commit details
    Browse the repository at this point in the history

  15. Also remap bg identifiers when pasting a full var glyph

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    a88f6e0 View commit details
    Browse the repository at this point in the history

  16. When writing a new bg image, put the data into the cache, so we don't… 

    … have to load it
    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    d807348 View commit details
    Browse the repository at this point in the history

  17. Rename method to match reality

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    15399fa View commit details
    Browse the repository at this point in the history

  18. Move var into only scope where it's needed

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    4145e94 View commit details
    Browse the repository at this point in the history

  19. Set cache entry before resolving the promise

    @justvanrossum
    justvanrossum committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    6054a78 View commit details
    Browse the repository at this point in the history