[background image] Make image data participate in copy/paste #1795

justvanrossum · 2024-11-16T12:03:56Z

This fixes #1793.

This also implements writing background image data from the front end.

…age data can't be loaded

… have to load it

justvanrossum added 16 commits November 16, 2024 10:06

Add backgroundImageData arg to _writeLayersToClipboard

655a1ff

Factor out object construction from serialization

cc54bdf

If there's bg image data, add it to the json object

d35afed

Add bg image data for varGlyph copy; add stubs for other cases

87c62cd

Add image data for layer glyph copy

978e001

Make support for bg images detectable

96245d7

Make new imageIdentifiers for bg images when pasting

b9e4b13

Add FontHandler.putBackgroundImage()

2f40c24

Refactor so we can also add stuff to the cache from the clipboard, etc.

fe097d8

Fix remote method signature

57cce12

Fix caching approach; implement writing bg image data

c40e84b

Write pasted bg images, and make sure they have unique identifiers

cb63c6b

Rename method; ensure the imagePromise gets resolved even when the im…

c8166ca

…age data can't be loaded

Add null image

19ecb8c

Also remap bg identifiers when pasting a full var glyph

a88f6e0

When writing a new bg image, put the data into the cache, so we don't…

d807348

… have to load it

justvanrossum marked this pull request as ready for review November 16, 2024 17:45

justvanrossum added 3 commits November 16, 2024 18:47

Rename method to match reality

15399fa

Move var into only scope where it's needed

4145e94

Set cache entry before resolving the promise

6054a78

justvanrossum merged commit 1d67e6c into main Nov 16, 2024
5 checks passed

justvanrossum deleted the bg-image-data-issue1793 branch November 16, 2024 17:55

Provide feedback