Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Qt-specific code being split into glue-qt #2431

Merged
merged 28 commits into from
Aug 15, 2023

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Aug 10, 2023

This is part of #2430

Packages that will need to be updated to use glue-qt wherever relevant:

@astrofrog astrofrog changed the title Remove Qt-specific code Remove Qt-specific code being split into glue-qt Aug 10, 2023
Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/conf.py:6:1: F401 'sys' imported but unused

also keeping the tests from running

glue/core/cli_parsers/__init__.py Outdated Show resolved Hide resolved
@Carifio24
Copy link
Member

I think glue-wwt should be in the "needs updating" list as well, as it has some Qt-based glue imports.

@dhomeier
Copy link
Collaborator

Tests for glue-jupyter are passing with this version and no Qt installed (except for those requiring glue-vispy-viewers, which cannot be installed without PyQt).

@astrofrog
Copy link
Member Author

@dhomeier - hmm good point about glue-vispy-viewers - I think we should probably move the 3D state objects out of glue-vispy-viewers and into glue-core since they should be reasonably generic, and then we could depend on that instead of glue-vispy-viewers in glue-jupyter.

@dhomeier
Copy link
Collaborator

except for those requiring glue-vispy-viewers, which cannot be installed without PyQt).

The depency is only on conda-forge though; with pip-installed glue-vispy-viewers the other tests are passing as well...

@astrofrog
Copy link
Member Author

I think the thing is that glue-jupyter does depend on glue-vispy-viewers for the 3D volume rendering viewer but we just haven't declared the dependency. However we should be able to refactor things to not have that dependency at all. I think I will delay this until after glue-core and glue-qt are split.

@astrofrog
Copy link
Member Author

I'm going to go ahead and merge this as I think it is ready. I will also merge glue-viz/glue-qt#1 shortly. I will then do a release of glue-qt and add it as a dependency in glue-core so that glue-core should then continue to function as before just with deprecation warnings being raised now when Qt-related functionality is accessed.

@astrofrog astrofrog marked this pull request as ready for review August 15, 2023 14:05
@astrofrog astrofrog merged commit bd11f6b into glue-viz:main Aug 15, 2023
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants