-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Qt-specific code being split into glue-qt #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/conf.py:6:1: F401 'sys' imported but unused
also keeping the tests from running
… longer really needed (pip freeze or conda list are usually sufficient) and also remove most of glue.main which concerned the Qt application
I think |
Tests for glue-jupyter are passing with this version and no Qt installed (except for those requiring glue-vispy-viewers, which cannot be installed without PyQt). |
@dhomeier - hmm good point about glue-vispy-viewers - I think we should probably move the 3D state objects out of glue-vispy-viewers and into glue-core since they should be reasonably generic, and then we could depend on that instead of glue-vispy-viewers in glue-jupyter. |
The depency is only on conda-forge though; with pip-installed glue-vispy-viewers the other tests are passing as well... |
I think the thing is that glue-jupyter does depend on glue-vispy-viewers for the 3D volume rendering viewer but we just haven't declared the dependency. However we should be able to refactor things to not have that dependency at all. I think I will delay this until after glue-core and glue-qt are split. |
…ecated imports from DeprecationWarning to GlueDeprecationWarning
I'm going to go ahead and merge this as I think it is ready. I will also merge glue-viz/glue-qt#1 shortly. I will then do a release of glue-qt and add it as a dependency in glue-core so that glue-core should then continue to function as before just with deprecation warnings being raised now when Qt-related functionality is accessed. |
This is part of #2430
Packages that will need to be updated to use glue-qt wherever relevant: