-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for glue-qt #98
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 18 18
Lines 992 992
=======================================
Hits 675 675
Misses 317 317
☔ View full report in Codecov by Sentry. |
I've now released glue-qt v0.1.0 so you should be able to add that package as a dependency here (at least for the testing - we probably don't want it to be a compulsory runtime dependency in case glue-wwt is used in jupyter for instance). |
@astrofrog I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Feel free to merge once you are happy with it
This PR will update glue-wwt to be compatible with the new
glue-qt
package, once we're ready for that (see glue-viz/glue#2431). If the locations of things change, I will update here.To do: