-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove asynchronous=False
from runJavaScript calls
#84
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 71.97% 73.25% +1.27%
==========================================
Files 18 18
Lines 860 860
==========================================
+ Hits 619 630 +11
+ Misses 241 230 -11
Continue to review full report at Codecov.
|
@dhomeier is this still needed? can you rebase? |
Attempting to run without |
There may be some useful hints in https://stackoverflow.com/a/60831141 for implementing an alternative. |
Description
Currently causing failures
on all Python 3.7+ tests although all the Qt* modules seem to be on the same versions as in the 3.6 envs.
Search of the QtWebEngine docs did not bring up anything about a deprecation or potential replacement, rather appears it is now running asynchronously by default, so just giving this a try.