-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CI from Azure to GitHub actions #82
Conversation
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 74.18% 71.97% -2.21%
==========================================
Files 18 18
Lines 860 860
==========================================
- Hits 638 619 -19
- Misses 222 241 +19
Continue to review full report at Codecov.
|
1a027a9
to
edb2c88
Compare
2302691
to
2b5a9cd
Compare
c381ace
to
ce17c42
Compare
Yes, just thought so as well – and the Windows jobs seemed to be stuck for 15 minutes after the actual tox runs again. |
f4930cf
to
dcb802e
Compare
Mysteriously the Windows runs are no longer hanging – or could it have been the switch to v1.0.2? |
@astrofrog I don't know if there is a syntax to pull the dev branch of the workflows for testing if the The Shapely 1.8.0 installations on macOS and Windows py310 seem to have similar |
OK, that would be better than accidentally staying stuck at @v1.0.2 in any case. |
So mac and win py310 have updated there Shapely as well. |
Ok thanks! You can now revert back to using the default fast-fail as v1.0.3 of the workflows is out. Also I think we can drop Python 3.6 as glue-core requires 3.7 (https://github.com/glue-viz/glue/blob/main/setup.cfg#L26) which might help resolve the remaining CI issues. Can you update this in setup.cfg too? |
Already used in the last run (set in |
I think we should just remove the fast-fail options from our config now - the default of 'false' is what we want I think |
The default was I think the middle path recommended for astropy coordinated packages was to define a smaller set of mandatory tests that first have to pass (actually not starting the full set before that, which seems not possible here, but at least anything failing early on on setup or so would cancel the remaining jobs soon). But for this repo perhaps not so useful, since there are no environments with minimal deps or dev/very extended tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I agree about trying to follow something more like what we do in astropy with different stages of testing, though packages like this are low traffic enough that I'm not sure if it's worth the extra complexity. Fast failing is not a good option in any case as if you run the CI again you might not have the same job fail which makes debugging impossible.
Description
Transition using the reusable workflows from https://github.com/OpenAstronomy/github-actions-workflows