Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-358: add static types support #368
gh-358: add static types support #368
Changes from 128 commits
4ba78c1
b23ded0
b9ee0eb
3f80029
79f1ac3
3856aa9
58696dc
d22891e
e6c8f77
ef1c0d9
f53ffc5
46c75e9
cdc4312
6e456e8
5b3a94c
ec53ba5
e59a5fa
d4e5396
a2a1a5f
c2c145b
b28be77
9151d81
cc07ade
6883e1c
c11e82f
3d894b4
12ad51a
5bf6a27
aab5b92
0ff8b08
fe9daf2
c858c98
cc231ed
6aff2ea
12723f8
52b2fc8
050c36a
74a94de
0864ddb
2e2020f
bc62666
27f4ab4
c1fdd6d
6d6d447
484c7bd
7ddf501
7b66122
008e9a5
112c36c
394f458
c9b4b63
57f2820
205ae4c
42cb3b8
8f4f79f
f165dcb
3d86e19
e809b1c
cb2b05c
b9ddf83
9ebfa62
a5b0f7b
7fe9725
eaa525c
a8753f3
4ed953b
5d4b632
ce10ed0
d6c1cfb
b1d0131
fca667e
c58fc87
16e7b15
7c9341b
7b6d294
6e0f29d
0b8d071
6c8f924
7b2703f
a6af6ea
aff1581
e3722a7
b70ad8a
f9814ce
487810b
1c2296a
43ad02c
2e73bce
cebe357
f08ab67
41c129b
015496c
1e154e1
a10fab9
994fdf3
85961b8
6e7efbe
48cdb53
b730b32
3c097ca
aa92c4d
1c77c15
426db7b
8971dad
ddfe641
3f9c158
3f63c2e
4d78c5e
2cb042d
0a0ed29
5603418
5e520ce
9b5a011
f672986
64d6991
29a685e
fada69c
22efda8
3a7a1d0
88f41c6
e7cdfd6
61e273e
a921881
1965509
05ad150
372226b
c200a5d
9062f17
0b4a446
6c47fcd
f021549
c0177c5
6012cb6
437bba3
6a869b4
00205d7
397efe3
5f3d17e
5a16b36
ea4a36b
43b20d0
938782c
152c214
0dca63b
7c30d01
4d6bcb4
0df5a8c
f5ea6cd
4961d2e
e96403f
0afdd0e
515ed8c
391a27a
7af8b51
b2df82c
6ea68e0
dc5bfdf
de9cdc9
882e7ec
113d4aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is really a change that needs to happen in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but can we leave it? I had to run them to see the outputs for typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also make sense to me to include only
glass/
in the type checking.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, it is only possible to exclude modules. Excluding folders doesn't seem supported python/mypy#17977
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not suffice to add
packages = "glass"
to[tool.mypy]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried that and it didn't work... 🤔