gh-358: add static types support #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saransh-cpp
reviewed
Nov 5, 2024
Comment on lines
-134
to
-137
| "ANN001", # TODO: missing-type-function-argument | ||
| "ANN002", # TODO: missing-type-args | ||
| "ANN003", # TODO: missing-type-kwargs | ||
| "ANN201", # TODO: missing-return-type-undocumented-public-function |
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
ntessore
reviewed
Nov 6, 2024
|
@ntessore I've addressed through your comments |
Saransh-cpp
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Awesome! Thanks for putting so much efforts into this, @paddyroddy!
|
Thanks both for the review. Will merge this and update the downstream PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358. Replaces #308.
This PR adds static type support, hence satisfying
mypy. With the adaptation of #67 I anticipate typing to change, but it's much easier to do oncemypyis passing initially.The only
# type: ignore[]comments remaining areattr-definedwhich are all attributed tonp.trapz, those can easily be fixed by #207.I have turned off:
disallow_untyped_decoratorsthis is being triggered bypytestandnox. The equivalent# type: ignore[]error ismiscwhich isn't the most informativewarn_return_anywhich is due to external libraries likecosmology- this could be revisited in the futureI have decided to re-write some of the tests which were simply not following the typing - like passing is a
listrather than anp.ndarray. The alternative approach would be having really messy typing.I'm not expecting this to be fully perfect. We will likely have to iterate on this, and completely change once we follow #67. But this is a good first step.
Do make sure to look carefully. Hard to avoid such a big PR with this. There were over 200
# type: ignore[]comments to fix!