Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Malware Topic #4135

Closed
wants to merge 16 commits into from
Closed

Create Malware Topic #4135

wants to merge 16 commits into from

Conversation

EmperialX
Copy link

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

This changes were not in present topic

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

it's change the view for the topic.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

This changes will will give enhanced view for the topic.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@EmperialX EmperialX requested a review from a team as a code owner December 26, 2023 11:46
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution. Unfortunately there are several problems with the PR you've submitted. IAs it is right now, it fails both the "conflict of interest" and "generally useful to community" provisions of our Contribution Guidelines. If you remove everything except the aliases and related fields in fastapi, we could merge it.

github_url: https://github.com/tiangolo/fastapi
created_by: Sebastián Ramírez
---
FastAPI is a high performance, easy to learn, fast to code, and ready for production Python 3.7+ framework. Its performance is on par with NodeJS and Go (thanks to Starlette and Pydantic). It's intuitive and standards-based (based on API standards like OpenAPI (previously known as Swagger) and JSON Schema).

**FastAPI** is a high-performance, easy-to-learn, fast-to-code Python 3.7+ framework ready for production. It boasts performance on par with NodeJS and Go, thanks to Starlette and Pydantic. FastAPI is intuitive and standards-based, following API standards like OpenAPI (previously known as Swagger) and JSON Schema.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This restates the existing description in slightly different words and does not add any new information.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

**FastAPI** is a high-performance, easy-to-learn, fast-to-code Python 3.7+ framework ready for production. It boasts performance on par with NodeJS and Go, thanks to Starlette and Pydantic. FastAPI is intuitive and standards-based, following API standards like OpenAPI (previously known as Swagger) and JSON Schema.

# Other resources
- For more information, visit the [official FastAPI GitHub repository](https://github.com/tiangolo/fastapi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link will be created automatically due to the github_url field, so it is redundant.

Comment on lines +7 to +8
github_url: https://github.com/EmperialX/System-Monitor
created_by: "@Emperialx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may not claim the general topic name malware for your personal project.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay done , thanks for the suggestions. i have deleted malware directory and updated fastapi only with aliases and related topic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you help me , how can i add my project in general category so it can stand out in the listing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can i add my project in general category so it can stand out in the listing?

That's not what this part of GitHub is intended for.

Again, you need to remove the references to your project in order to get this merged. so the description, created_by and github_url lines need to be deleted.

@EmperialX EmperialX requested a review from ahpook December 26, 2023 16:53
@github github deleted a comment from EmperialX Dec 31, 2023
Comment on lines +7 to +8
github_url: https://github.com/EmperialX/System-Monitor
created_by: "@Emperialx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can i add my project in general category so it can stand out in the listing?

That's not what this part of GitHub is intended for.

Again, you need to remove the references to your project in order to get this merged. so the description, created_by and github_url lines need to be deleted.

@alisamki
Copy link

alisamki commented Jan 5, 2024

@EmperialX for the topics/malware/index.md you would just want to update the code to something like this:

---
aliases: virus, computer-malware
display_name: Malware
short_description: "Any program or file that is intentionally harmful to a computer, network or server"
related: virus, security, malware-analysis, cyber-attack, cyber-security, system-tracking, system-monitoring
topic: malware
logo: malware.png
wikipedia_url: https://en.wikipedia.org/wiki/Malware
---
Malware can take various forms, including viruses, worms, Trojans, ransomware, spyware, and more. Its primary goal is to compromise the integrity, confidentiality, or availability of information, often for financial gain, espionage, or other malicious purposes.

@ahpook
Copy link
Contributor

ahpook commented Jan 11, 2024

I'm going to close this PR as it hasn't gotten the requested changes. @EmperialX if you want to get this in, please make the changes as suggested by @Colack in the comment above and open a new PR.

@ahpook ahpook closed this Jan 11, 2024
@alisamki alisamki mentioned this pull request Jan 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants