-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Malware Topic #4135
Create Malware Topic #4135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution. Unfortunately there are several problems with the PR you've submitted. IAs it is right now, it fails both the "conflict of interest" and "generally useful to community" provisions of our Contribution Guidelines. If you remove everything except the aliases
and related
fields in fastapi
, we could merge it.
github_url: https://github.com/tiangolo/fastapi | ||
created_by: Sebastián Ramírez | ||
--- | ||
FastAPI is a high performance, easy to learn, fast to code, and ready for production Python 3.7+ framework. Its performance is on par with NodeJS and Go (thanks to Starlette and Pydantic). It's intuitive and standards-based (based on API standards like OpenAPI (previously known as Swagger) and JSON Schema). | ||
|
||
**FastAPI** is a high-performance, easy-to-learn, fast-to-code Python 3.7+ framework ready for production. It boasts performance on par with NodeJS and Go, thanks to Starlette and Pydantic. FastAPI is intuitive and standards-based, following API standards like OpenAPI (previously known as Swagger) and JSON Schema. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This restates the existing description in slightly different words and does not add any new information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
topics/fastapi/index.md
Outdated
**FastAPI** is a high-performance, easy-to-learn, fast-to-code Python 3.7+ framework ready for production. It boasts performance on par with NodeJS and Go, thanks to Starlette and Pydantic. FastAPI is intuitive and standards-based, following API standards like OpenAPI (previously known as Swagger) and JSON Schema. | ||
|
||
# Other resources | ||
- For more information, visit the [official FastAPI GitHub repository](https://github.com/tiangolo/fastapi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link will be created automatically due to the github_url
field, so it is redundant.
github_url: https://github.com/EmperialX/System-Monitor | ||
created_by: "@Emperialx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may not claim the general topic name malware
for your personal project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay done , thanks for the suggestions. i have deleted malware directory and updated fastapi only with aliases and related topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help me , how can i add my project in general category so it can stand out in the listing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can i add my project in general category so it can stand out in the listing?
That's not what this part of GitHub is intended for.
Again, you need to remove the references to your project in order to get this merged. so the description
, created_by
and github_url
lines need to be deleted.
github_url: https://github.com/EmperialX/System-Monitor | ||
created_by: "@Emperialx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can i add my project in general category so it can stand out in the listing?
That's not what this part of GitHub is intended for.
Again, you need to remove the references to your project in order to get this merged. so the description
, created_by
and github_url
lines need to be deleted.
@EmperialX for the topics/malware/index.md you would just want to update the code to something like this: ---
aliases: virus, computer-malware
display_name: Malware
short_description: "Any program or file that is intentionally harmful to a computer, network or server"
related: virus, security, malware-analysis, cyber-attack, cyber-security, system-tracking, system-monitoring
topic: malware
logo: malware.png
wikipedia_url: https://en.wikipedia.org/wiki/Malware
---
Malware can take various forms, including viruses, worms, Trojans, ransomware, spyware, and more. Its primary goal is to compromise the integrity, confidentiality, or availability of information, often for financial gain, espionage, or other malicious purposes. |
I'm going to close this PR as it hasn't gotten the requested changes. @EmperialX if you want to get this in, please make the changes as suggested by @Colack in the comment above and open a new PR. |
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png
, square, dimensions 288x288, size <= 75 kB)index.md
)Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.