Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'malware' topic. #4189

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Create 'malware' topic. #4189

merged 6 commits into from
Jan 23, 2024

Conversation

Colack
Copy link
Contributor

@Colack Colack commented Jan 18, 2024

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

I'm taking the changes that I mention in this pull request and putting them here. Essentially just adding the malware topic with an image.

Colack added 3 commits January 5, 2024 09:28
Copied from another pull request. I'll state that in the full pull request.
@Colack Colack requested a review from a team as a code owner January 18, 2024 17:56
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple problems to get tests passing, but thanks for picking this one up @Colack !

@@ -0,0 +1,10 @@
---
aliases: virus, computer-malware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aliases: virus, computer-malware
aliases: computer-malware

you can't have the same thing as both an alias and a 'related' item

---
aliases: virus, computer-malware
display_name: Malware
short_description: "Any program or file that is intentionally harmful to a computer, network or server"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
short_description: "Any program or file that is intentionally harmful to a computer, network or server"
short_description: "Any program or file that is intentionally harmful to a computer, network or server."

short_description needs to end with punctuation.

@Colack Colack requested a review from ahpook January 23, 2024 16:03
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@ahpook ahpook added this pull request to the merge queue Jan 23, 2024
Merged via the queue into github:main with commit f7b4045 Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants