-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 'malware' topic. #4189
Create 'malware' topic. #4189
Conversation
Copied from another pull request. I'll state that in the full pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple problems to get tests passing, but thanks for picking this one up @Colack !
topics/malware/index.md
Outdated
@@ -0,0 +1,10 @@ | |||
--- | |||
aliases: virus, computer-malware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aliases: virus, computer-malware | |
aliases: computer-malware |
you can't have the same thing as both an alias and a 'related' item
topics/malware/index.md
Outdated
--- | ||
aliases: virus, computer-malware | ||
display_name: Malware | ||
short_description: "Any program or file that is intentionally harmful to a computer, network or server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
short_description: "Any program or file that is intentionally harmful to a computer, network or server" | |
short_description: "Any program or file that is intentionally harmful to a computer, network or server." |
short_description needs to end with punctuation.
Added the changes suggested from the pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for this!
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsI'm taking the changes that I mention in this pull request and putting them here. Essentially just adding the malware topic with an image.