Expose :value in SingleExceptionInterface
#2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose `:value` in `SingleExceptionInterface` for users wishing to do basic sanitization of the exception message string in `before_send()`. For example, theproject does basic sanitization of `:value` using `sentry-raven`: https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/lib/dependabot/sentry.rb#L21 So exposing this makes the migration path easier for those users. And makes it possible for anyone else to do basic redaction of potential secrets, etc. Fix #2071
|
I should caveat this PR with a note that I'm relatively new to Ruby, so if the goal is reasonable but the implementation is lacking, please point me in the right direction. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2072 +/- ##
==========================================
+ Coverage 83.23% 83.25% +0.02%
==========================================
Files 119 119
Lines 5665 5666 +1
==========================================
+ Hits 4715 4717 +2
+ Misses 950 949 -1
☔ View full report in Codecov by Sentry. |
sl0thentr0py
approved these changes
Jul 27, 2023
|
Awesome thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
:valueinSingleExceptionInterfacefor users wishing to do basic sanitization of the exception message string inbefore_send().For example, the
project does basic sanitization of
:valueusingsentry-raven:https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/lib/dependabot/sentry.rb#L21
So exposing this makes the migration path easier for those users. And makes it possible for anyone else to do basic redaction of potential secrets, etc.
Fix #2071