-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose :value
in SingleExceptionInterface
#2071
Comments
For now I've hacked around it using |
yea I can expose it, PR obviously welcome to speed it up |
Thanks, I put up a PR to expose it two weeks ago: |
sorry didn't see that, need some time to catch up with this repo |
👋 Hi from the team.
I'm attempting to migrate from
sentry-raven
tosentry-ruby
:sentry-raven
tosentry-ruby
dependabot/dependabot-core#7553With Raven we performed some basic client-side sanitization of the exception message:
https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/lib/dependabot/sentry.rb#L5-L21
The unit tests illustrate how it works:
https://github.com/dependabot/dependabot-core/blob/65f1c2d24e88ac57ed8df980871446deb5ea2d94/updater/spec/dependabot/sentry_spec.rb#L24-L91
Migrating this from Raven to
sentry-ruby
'sbefore_send
is straightforward. However, it looks likesentry-ruby
doesn't expose:value
onSingleExceptionInterface
:sentry-ruby/sentry-ruby/lib/sentry/interfaces/single_exception.rb
Line 14 in 7764384
I see a recent change was made to expose
:values
onExceptionInterface
::values
inExceptionInterface
#1843So I'm guessing there's no technical reason this can't be made publicly writable? Just no one has raised a feature request for it yet?
The text was updated successfully, but these errors were encountered: