feat(xcode): All uploads in foreground #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
requested review from
loewenheim,
krystofwoldrich and
a team
loewenheim
approved these changes
Sep 27, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/refactor-may-detach
branch
from
79da60f
to
2795780
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-background-upload
branch
from
668620f
to
063f40b
Compare
loewenheim
approved these changes
Sep 27, 2024
|
@mitsuhiko it appears you were the one who originally added the background upload functionality in 2017, or perhaps even earlier. Are you at all opposed to removing the background upload functionality completely? Happy to provide more context if needed |
|
As stated on Slack, there is nothing against this from the mobile side. We only need to ensure that we keep the same functionality in the https://github.com/getsentry/sentry-fastlane-plugin when updating to the sentry-cli version, including this PR. |
|
I have no context sadly any more on any of this. I assume it was super slow originally. |
|
Okay, thanks everyone! I will go ahead with merging and releasing this change, and I will monitor for any user feedback. We can adjust accordingly |
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-background-upload
branch
from
063f40b
to
d060289
Compare
szokeasaurusrex
changed the base branch from
szokeasaurusrex/refactor-may-detach
to
master
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old `--force-foreground` behavior. Since uploads are now always executed in the foreground, (soft) deprecate the `--force-foreground` option by hiding it in the command help text. The `--force-foreground` option no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible. Background functionality is completely removed from Sentry-CLI with this change. Closes #2166 Fixes #2148
szokeasaurusrex
force-pushed
the
szokeasaurusrex/remove-background-upload
branch
from
d060289
to
4afa9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old
--force-foregroundbehavior.Since uploads are now always executed in the foreground, (soft) deprecate the
--force-foregroundoption by hiding it in the command help text. The--force-foregroundoption no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible.Background functionality is completely removed from Sentry-CLI with this change.
Closes #2166
Fixes #2148