Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove background upload functionality #2166

Closed
szokeasaurusrex opened this issue Sep 27, 2024 · 0 comments · Fixed by #2168
Closed

Remove background upload functionality #2166

szokeasaurusrex opened this issue Sep 27, 2024 · 0 comments · Fixed by #2168
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

The background upload functionality is difficult to debug, since in cases like as in the parent issue, it is possible for the Sentry CLI to crash silently. Users may not notice that their debug files have not been uploaded.

Removing the background upload functionality likely will also simplify the Sentry CLI code.

Users who want to upload in the background can likely modify their shell script to call the Sentry CLI in the background. We should consider documenting how to do this.
@szokeasaurusrex szokeasaurusrex self-assigned this Sep 27, 2024
szokeasaurusrex added a commit that referenced this issue Sep 27, 2024
@szokeasaurusrex
ref: Extract MayDetach wrapped calls into separate methods
cf3c3a9 
Done in preparation for #2166, to make that change's diff smaller and easier to understand.
@szokeasaurusrex szokeasaurusrex mentioned this issue Sep 27, 2024
Closed
szokeasaurusrex added a commit that referenced this issue Sep 27, 2024
@szokeasaurusrex
ref: Extract MayDetach wrapped calls into separate methods
79da60f 
Done in preparation for #2166, to make that change's diff smaller and easier to understand.
szokeasaurusrex added a commit that referenced this issue Sep 27, 2024
@szokeasaurusrex
feat(xcode): All uploads in foreground
668620f 
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old `--force-foreground` behavior.

Since uploads are now always executed in the foreground, (soft) deprecate the `--force-foreground` option by hiding it in the command help text. The `--force-foreground` option no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible.

Background functionality is completely removed from Sentry-CLI with this change.

Closes #2166
Fixes #2148
@szokeasaurusrex szokeasaurusrex mentioned this issue Sep 27, 2024
Merged
@szokeasaurusrex szokeasaurusrex linked a pull request Sep 27, 2024 that will close this issue
feat(xcode): All uploads in foreground #2168
Merged
szokeasaurusrex added a commit that referenced this issue Sep 27, 2024
@szokeasaurusrex
ref: Extract MayDetach wrapped calls into separate methods
2795780 
Done in preparation for #2166, to make that change's diff smaller and easier to understand.
szokeasaurusrex added a commit that referenced this issue Sep 27, 2024
@szokeasaurusrex
feat(xcode): All uploads in foreground
063f40b 
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old `--force-foreground` behavior.

Since uploads are now always executed in the foreground, (soft) deprecate the `--force-foreground` option by hiding it in the command help text. The `--force-foreground` option no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible.

Background functionality is completely removed from Sentry-CLI with this change.

Closes #2166
Fixes #2148
szokeasaurusrex added a commit that referenced this issue Oct 3, 2024
@szokeasaurusrex
feat(xcode): All uploads in foreground
d060289 
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old `--force-foreground` behavior.

Since uploads are now always executed in the foreground, (soft) deprecate the `--force-foreground` option by hiding it in the command help text. The `--force-foreground` option no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible.

Background functionality is completely removed from Sentry-CLI with this change.

Closes #2166
Fixes #2148
szokeasaurusrex added a commit that referenced this issue Oct 3, 2024
@szokeasaurusrex
feat(xcode): All uploads in foreground
4afa9f0 
Perform all uploads from Xcode in the foreground. The new behavior is equivalent to the old `--force-foreground` behavior.

Since uploads are now always executed in the foreground, (soft) deprecate the `--force-foreground` option by hiding it in the command help text. The `--force-foreground` option no longer has any effect, but passing it will continue to be possible at least until the next major release to keep the API backwards compatible.

Background functionality is completely removed from Sentry-CLI with this change.

Closes #2166
Fixes #2148
szokeasaurusrex added a commit that referenced this issue Oct 3, 2024
@szokeasaurusrex
ref: Extract MayDetach wrapped calls into separate methods
e10ccf5 
Done in preparation for #2166, to make that change's diff smaller and easier to understand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(xcode): All uploads in foreground getsentry/sentry-cli
1 participant
@szokeasaurusrex