Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lower specificity for hover transitions #3295

Merged
merged 4 commits into from
Sep 5, 2024
Merged

fix: lower specificity for hover transitions #3295

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55e621c
fix: lower specificity for hover transitions
Arukuen Aug 19, 2024
178703c
fix: added variable --stk-transition-default to be used for overwriti…
Arukuen Aug 19, 2024
382f822
chore: revert specificity changes
Arukuen Aug 27, 2024
0e451d6
chore: revert deleted comment
Arukuen Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/styles/block-transitions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ body.stk--anim-init {
.stk-img-wrapper::before, // Image block hover ovelay.
.stk-block li::marker, // For icon list marker
.stk-block-tabs__tab { // Tabs block
transition: all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95), flex 0s, max-width 0s, visibility 0s; // Don't include flex & max-width since column widths would animate.
transition: var(--stk-transition-default, all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95), flex 0s, max-width 0s, visibility 0s); // Don't include flex & max-width since column widths would animate.
border-width: 1px;
border-style: none;
}
.stk--svg-wrapper :is(.stk--shape-icon, .stk--inner-svg, .stk--inner-svg *) {
transition: all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95);
transition: var(--stk-transition-default, all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95));
}
// Icons can have a delay in transitions. It's more apparent when transitioning fill, removing it seems to fix this.
.stk--svg-wrapper .stk--inner-svg svg:last-child {
transition: all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95), fill 0s;
transition: var(--stk-transition-default, all var(--stk-transition-duration, 0.12s) cubic-bezier(0.45, 0.05, 0.55, 0.95), fill 0s);
}
}

Expand Down
Loading