Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower specificity for hover transitions #3295

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Aug 19, 2024

fixes #3266

image

  • Lowers specificity to from (0,3,1) to (0,1,0)
  • Added the variable --stk-transition-default that can be used for overwriting the transition property

Copy link

github-actions bot commented Aug 19, 2024

🤖 Pull request artifacts

file commit
pr3295-stackable-3295-merge.zip 0e451d6

github-actions bot added a commit that referenced this pull request Aug 19, 2024
github-actions bot added a commit that referenced this pull request Aug 19, 2024
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing this PR and the changes that we will introduce, I am uneasy changing a huge amount of specificity to something that's already working without any problems.

Let's change this PR to just include the new custom property --stk-transition-default. Let's revert back to the original selectors.

github-actions bot added a commit that referenced this pull request Aug 27, 2024
@bfintal bfintal merged commit 7985259 into develop Sep 5, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3266-transition-specificity branch September 5, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transitions with high specificity added
2 participants