Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't terminate DL binary client subprocesses when the parent process is SIGTERM'd #77

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Don't terminate DL binary client subprocesses when the parent process is SIGTERM'd #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions js/src/binary-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ export class DateiLagerBinaryClient {
}
const subprocess = execa(this._options.command, baseArgs.concat(args), {
cwd,
cleanup: false, // don't terminate this subprocess process eagerly when the parent process is terminated, which is execa's default behaviour. we use graceful shutdown gadget-side to give running operations a chance to complete, and we don't want to terminate them prematurely
timeout: options?.timeout ?? this._options.timeout[method],
env: { DL_TOKEN: await this._options.token() },
});
Expand Down
Loading