Don't terminate DL binary client subprocesses when the parent process is SIGTERM'd #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is SIGTERM'd We were seeing failures in Gadget during deploys where a running pod would be doing DL work and get SIGTERM'd by kubernetes. Normally, unixes will only deliver that signal to the parent process, but `execa` takes care to propagate SIGTERMs from the parent to any spawned children. This has the effect of prematurely killing a dl binary client subprocess mid operation. We use graceful shutdown in gadget to allow currently-running operations within our workers to finish, and so to allow that, we don't want these signals propagated.
angelini
approved these changes
Mar 11, 2024
|
@airhorns I'm gonna manage deploying a new DL version and getting this into Gadget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing failures in Gadget during deploys where a running pod would be doing DL work and get SIGTERM'd by kubernetes. Normally, unixes will only deliver that signal to the parent process, but
execatakes care to propagate SIGTERMs from the parent to any spawned children. This has the effect of prematurely killing a dl binary client subprocess mid operation. We use graceful shutdown in gadget to allow currently-running operations within our workers to finish, and so to allow that, we don't want these signals propagated.