Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of deprecated AsyncParametersClient constructor #319

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

achim-k
Copy link
Collaborator

@achim-k achim-k commented Jul 30, 2024

Changelog

Fix usage of deprecated AsyncParametersClient constructor (rolling)

Docs

None

Description

Fixes rolling build farm builds. The deprecated constructor has been removed in https://github.com/ros2/rclcpp/pull/2575/files#diff-e12b42b281d50847c271fe5c11443f00d55f363aae9c4bbf097fa19da0c36e5a

@achim-k achim-k requested a review from jtbandes July 30, 2024 08:04
Copy link

linear bot commented Jul 30, 2024

@defunctzombie defunctzombie merged commit 05f362a into main Jul 30, 2024
9 checks passed
@defunctzombie defunctzombie deleted the achim/fg-8334-fix-foxglove_bridge-rolling-builds branch July 30, 2024 16:33
@achim-k achim-k mentioned this pull request Jul 31, 2024
jtbandes pushed a commit that referenced this pull request Jul 31, 2024
### Changelog
- Fix usage of deprecated AsyncParametersClient constructor (#319)
- Add ROS2 JSON publishing support (#307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants