Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential for documentation copy-paste error #295

Closed
wants to merge 1 commit into from

Conversation

ZeKaiCheong
Copy link

@ZeKaiCheong ZeKaiCheong commented Apr 26, 2024

Changelog

Documentation typo error.

Description

The example given for including the foxglove bridge launch file in another XML launch file in ROS2 had an extra forward slash that was removed.

Prevent copy-paste issue.

BeforeAfter
[INFO] [launch]: Default logging verbosity is set to INFO
[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught multiple exceptions when trying to load file of format [xml]:
 - InvalidFrontendLaunchFileError: Caught multiple exceptions when trying to load file of format [xml]:
 - ParseError: mismatched tag: line 6, column 4
 - RuntimeError: Expected only one root
 - SyntaxError: invalid syntax (foxglove_bridge_launch.xml, line 1)

Example used for including in another XML launch file in ROS2 had an extra forward slash. Caught me out as I hadn't included launch files in a launch file before.
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@defunctzombie defunctzombie enabled auto-merge (squash) April 26, 2024 15:00
@defunctzombie
Copy link
Contributor

Something is stuck with the CLA check so I made a separate PR with the fix: #296

auto-merge was automatically disabled April 26, 2024 15:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants