-
Notifications
You must be signed in to change notification settings - Fork 96
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rust: add sans-io linear reader (#1244)
### Changelog - Rust: Added a `sans_io` module to allow users to read MCAP data while remaining agnostic to I/O. Replace the internal implementation details of both the memory-mapped I/O and tokio-async read modules with this sans_io reader. ### Docs See generated rust docs. ### Description As we need more functionality from the async MCAP reader, I feel less comfortable adding those and not also ensuring they're available for the memory-mapped reader. This PR strips out all of that code and moves it into a [sans-io](https://sans-io.readthedocs.io/) reader module. The sans-io reader is a state machine with no dependency on any particular I/O framework. <!-- In addition to unit tests, describe any manual testing you did to validate this change. --> <table><tr><th>Before</th><th>After</th></tr><tr><td> <!--before content goes here--> </td><td> <!--after content goes here--> </td></tr></table> <!-- If necessary, link relevant Linear or Github issues. Use `Fixes: foxglove/repo#1234` to auto-close the Github issue or Fixes: FG-### for Linear isses. --> --------- Co-authored-by: Jacob Bandes-Storch <[email protected]>
- Loading branch information
Showing
15 changed files
with
1,334 additions
and
1,159 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.