Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) update changelog details #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HillaryManning
Copy link

Changelog

None

Docs

None

Description

Adding details about 'ignore-for-changelog' tag and how to handle feature flags.

Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: this will add the 'ignore-for-changelog' tag

As someone making a PR - I would say I don't really care about this nuance.


My opinion is there are too many words here and that folks will not read all this. I would cut down on the words and make this easier to follow.

@HillaryManning
Copy link
Author

: this will add the 'ignore-for-changelog' tag

As someone making a PR - I would say I don't really care about this nuance.

My opinion is there are too many words here and that folks will not read all this. I would cut down on the words and make this easier to follow.

As someone making a PR I care about that nuance because maybe I made a PR with no updates (wrote 'none' and got the tag), but then received PR feedback that led to more changes/something that should be included in the changelog (<-- this has happened to me multiple times). If I understand correctly: the tag would not be automatically removed even if I update the description (or would it?) and I should remove the tag manually.

Happy to simplify the text 👍

@defunctzombie
Copy link
Contributor

If I understand correctly: the tag would not be automatically removed even if I update the description (or would it?) and I should remove the tag manually.

@bahram should fix this if the tag is not removed automatically. No engineer should be managing this tag - all you need to do is ensure the PR description is good and accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants