-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gl batch addition #19
Changes from 6 commits
a39091e
8f13127
4a995be
7e13be2
26852e0
aed6104
89945be
0ff573d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: 'auto release' | ||
on: | ||
pull_request: | ||
types: | ||
- closed | ||
branches: | ||
- main | ||
|
||
jobs: | ||
call-workflow-passing-data: | ||
if: github.event.pull_request.merged | ||
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@feature/auto-releaser | ||
secrets: inherit |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,6 @@ target/ | |
dbt_modules/ | ||
logs/ | ||
dbt_packages/ | ||
.DS_Store | ||
.DS_Store | ||
env/ | ||
package-lock.yml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,22 @@ | ||
# dbt_sage_intacct v0.3.0 | ||
|
||
[PR #19](https://github.com/fivetran/dbt_sage_intacct/pull/19) includes the following updates. | ||
|
||
## 🚨 Breaking Changes 🚨 (within the upstream dbt_sage_intacct_source package): | ||
- Removal of the `_fivetran_deleted` field from the upstream `stg_sage_intacct__gl_detail` table due to this field being deprecated within the connector. The relevant information is now available within the `gl_batch` source table. For more details please refer to the relevant [dbt_sage_intacct_source v0.3.0 release](https://github.com/fivetran/dbt_sage_intacct_source/releases/tag/v0.3.0). | ||
|
||
## Bug Fixes | ||
- Added a new `int_sage_intacct__active_gl_detail` model. This model properly filters out any soft deleted GL Detail records by joining on the GL Batch staging model which contains the reference to if the transaction was deleted or not. | ||
- While this package still does not fully support multi-currency, a bugfix was applied in the `int_sage_intacct__general_ledger_balances` model to properly join on the `currency` field so duplicates would not be introduced in the end models. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A rather impactful find! |
||
- In addition to the above, the following combination of column uniqueness tests were updated to take `currency` into consideration: | ||
- `sage_intacct__general_ledger_by_period` | ||
- `sage_intacct__profit_and_loss` | ||
- `sage_intacct__balance_sheet` | ||
|
||
## Under the Hood | ||
- Updated Maintainer PR Template | ||
- Included auto-releaser GitHub Actions workflow to automate future releases | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😃 |
||
|
||
# dbt_sage_intacct v0.2.2 | ||
|
||
## Add Null to Coalesce clause: | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned in the validation, might want to mention that this could result in removed rows from downstream models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing! Added.