Feature/gl batch addition

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: Issue #13

This PR will result in the following new package version: v0.3.0

While this is not necessarily breaking, the upstream change in the source package is. Therefore, this should be recorded as a breaking change.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

🚨 Breaking Changes 🚨 (within the upstream dbt_sage_intacct_source package):

• Removal of the _fivetran_deleted field from the upstream stg_sage_intacct__gl_detail table due to this field being deprecated within the connector. The relevant information is now available within the gl_batch source table. For more details please refer to the relevant dbt_sage_intacct_source v0.3.0 release.

Bug Fixes

• Added a new int_sage_intacct__active_gl_detail model. This model properly filters out any soft deleted GL Detail records by joining on the GL Batch staging model which contains the reference to if the transaction was deleted or not.
• While this package still does not fully support multi-currency, a bugfix was applied in the int_sage_intacct__general_ledger_balances model to properly join on the currency field so duplicates would not be introduced in the end models.
• In addition to the above, the following combination of column uniqueness tests were updated to take currency into consideration:
  • sage_intacct__general_ledger_by_period
  • sage_intacct__profit_and_loss
  • sage_intacct__balance_sheet

Under the Hood

• Updated Maintainer PR Template
• Included auto-releaser GitHub Actions workflow to automate future releases

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt run –full-refresh && dbt test
• dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked, tagged, and properly assigned.
• All necessary documentation and version upgrades have been applied. Don't forget to update the version in the README if necessary.
• docs were regenerated (unless this PR does not include any code or yml updates).
• BuildKite integration tests are passing.
• Detailed validation steps have been provided below.

Detailed Validation

Please share any and all of your validation steps:

All validations were performed within the Sage Intacct Validations Hex workbook. Please refer to the Height ticket for a direct link to these validations. The Hex notebook includes the following validations:

• General Ledger row counts tying out and not fanning out with the new gl_detail to gl_batch join logic.
• Currency join condition working as intended.

If you had to summarize this PR in an emoji, which would it be?

🌽

[fivetran-joemarkiewicz]

To be switched before merge

[fivetran-catfritz]

Ran and tested locally. Just one small suggestion in the changelog, but otherwise lgtm!

[fivetran-catfritz]

😃

[fivetran-catfritz]

As you mentioned in the validation, might want to mention that this could result in removed rows from downstream models.

[fivetran-joemarkiewicz]

Sure thing! Added.

[fivetran-catfritz]

A rather impactful find!