Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSV Source #64

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add CSV Source #64

merged 1 commit into from
Sep 25, 2024

Conversation

jannden
Copy link
Contributor

@jannden jannden commented Sep 18, 2024

Closes #52 , https://github.com/famedly/product-management/issues/2038


Copy link

github-actions bot commented Sep 18, 2024

LCOV of commit d194640 during Rust workflow #376

Summary coverage rate:
  lines......: 86.9% (1139 of 1310 lines)
  functions..: 51.0% (270 of 529 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/config.rs      |96.2%    213|57.1%    98|    -      0
  src/sources/csv.rs |93.4%    151|56.7%    60|    -      0
  src/sources/ldap.rs|95.9%    319|59.3%   135|    -      0
  src/user.rs        |89.7%     68|54.5%    22|    -      0
  src/zitadel.rs     |76.7%    317|31.7%   120|    -      0

@jannden jannden force-pushed the jannden/csv-source branch 2 times, most recently from eba5607 to cd0edc0 Compare September 18, 2024 07:53
@jannden jannden marked this pull request as ready for review September 18, 2024 07:56
@jannden jannden requested a review from a team as a code owner September 18, 2024 07:56
@jannden
Copy link
Contributor Author

jannden commented Sep 18, 2024

The requirements were clarified and confirmed with the only stakeholder at the moment - the Marketing team. Task specified #52
Namely:

  • only importing new users,
  • skipping import for users that already exist,
  • reading CSV file from disk,
  • CSV data format: email,first_name,last_name,phone

src/sources/csv.rs Outdated Show resolved Hide resolved
config.sample.yaml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/sources/csv.rs Show resolved Hide resolved
src/sources/csv.rs Outdated Show resolved Hide resolved
src/sources/csv.rs Outdated Show resolved Hide resolved
src/user.rs Outdated Show resolved Hide resolved
tests/environment/files/test-users.csv Outdated Show resolved Hide resolved
@jannden jannden force-pushed the jannden/csv-source branch 2 times, most recently from 1bacc56 to 8088422 Compare September 19, 2024 07:19
@emgrav
Copy link
Member

emgrav commented Sep 19, 2024

UKF wants a similar feature, apparently. See the linked issue above. I think it would make sense to add fields for organization, project, and role.

Sorry about not catching this issue earlier

@nikzen
Copy link

nikzen commented Sep 19, 2024

UKF wants a similar feature, apparently. See the linked issue above. I think it would make sense to add fields for organization, project, and role.

Sorry about not catching this issue earlier

@emgrav THis is not required right now for UKF - so we can keep it as it is

@jannden jannden merged commit d194640 into main Sep 25, 2024
3 checks passed
@jannden jannden deleted the jannden/csv-source branch September 25, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSV source
5 participants