Rename a missed enum and a bit more #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 21, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
0dc2324
to
6412ae8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 22, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
6412ae8
to
cd07959
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
force-pushed
the
export-D56370309
branch
from
cd07959
to
3d7e09a
Compare
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
|
This pull request was exported from Phabricator. Differential Revision: D56370309 |
helfman
force-pushed
the
export-D56370309
branch
from
3d7e09a
to
ec8b398
Compare
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 Pull Request resolved: prestodb#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
added a commit
to helfman/presto
that referenced
this pull request
Apr 24, 2024
Summary: X-link: facebookincubator/nimble#30 Pull Request resolved: prestodb#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
ec8b398
to
a31d588
Compare
Summary: Pull Request resolved: facebookincubator/nimble#30 X-link: prestodb/presto#22577 X-link: facebookincubator/velox#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309
helfman
force-pushed
the
export-D56370309
branch
from
a31d588
to
0dcf773
Compare
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Apr 25, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: prestodb/presto#22577 Pull Request resolved: #9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309 fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
|
This pull request has been merged in c12e03c. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: X-link: facebookincubator/nimble#30 X-link: prestodb/presto#22577 Pull Request resolved: facebookincubator#9549 Found some enums that were left behind during the rename. Reviewed By: sdruzkin Differential Revision: D56370309 fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: prestodb/presto#22577
X-link: facebookincubator/velox#9549
Found some enums that were left behind during the rename.
Reviewed By: sdruzkin
Differential Revision: D56370309