Skip to content

Commit

Permalink
Rename a missed enum and a bit more (#30)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #30

X-link: prestodb/presto#22577

X-link: facebookincubator/velox#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309
  • Loading branch information
helfman authored and facebook-github-bot committed Apr 24, 2024
1 parent ddb6f1c commit 0dcf773
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dwio/nimble/tools/ParallelReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class ReaderFactory {
NIMBLE_ASSERT(readFile_->size() > 2, "Invalid read file size.");
uint16_t magicNumber;
readFile_->pread(readFile_->size() - 2, 2, &magicNumber);
format_ = (magicNumber == 0xA1FA) ? velox::dwio::common::FileFormat::ALPHA
format_ = (magicNumber == 0xA1FA) ? velox::dwio::common::FileFormat::NIMBLE
: velox::dwio::common::FileFormat::DWRF;
auto columnFeatures =
dwio::utils::feature_flattening::extractFeatureNames(readFile_);
Expand Down Expand Up @@ -166,7 +166,7 @@ class DwrfReader : public Reader {

std::unique_ptr<Reader> ReaderFactory::create(
velox::memory::MemoryPool& memoryPool) {
if (format_ == velox::dwio::common::FileFormat::ALPHA) {
if (format_ == velox::dwio::common::FileFormat::NIMBLE) {
return std::make_unique<NimbleReader>(memoryPool, readFile_, features_);
} else {
return std::make_unique<DwrfReader>(memoryPool, readFile_, features_);
Expand Down

0 comments on commit 0dcf773

Please sign in to comment.