Skip to content

Commit

Permalink
Rename a missed enum and a bit more (facebookincubator#9549)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/nimble#30

X-link: prestodb/presto#22577

Pull Request resolved: facebookincubator#9549

Found some enums that were left behind during the rename.

Reviewed By: sdruzkin

Differential Revision: D56370309

fbshipit-source-id: 24b76bd948778091ec12bdbee9138f108be51b07
  • Loading branch information
helfman authored and Joe-Abraham committed Jun 7, 2024
1 parent 5a171c5 commit bf954a4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 4 additions & 4 deletions velox/dwio/common/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ FileFormat toFileFormat(std::string s) {
return FileFormat::JSON;
} else if (s == "parquet") {
return FileFormat::PARQUET;
} else if (s == "alpha") {
return FileFormat::ALPHA;
} else if (s == "nimble") {
return FileFormat::NIMBLE;
} else if (s == "orc") {
return FileFormat::ORC;
}
Expand All @@ -60,8 +60,8 @@ std::string toString(FileFormat fmt) {
return "json";
case FileFormat::PARQUET:
return "parquet";
case FileFormat::ALPHA:
return "alpha";
case FileFormat::NIMBLE:
return "nimble";
case FileFormat::ORC:
return "orc";
default:
Expand Down
4 changes: 4 additions & 0 deletions velox/dwio/common/Options.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ enum class FileFormat {
TEXT = 5,
JSON = 6,
PARQUET = 7,
#ifdef VELOX_ENABLE_BACKWARD_COMPATIBILITY
ALPHA = 8,
#else
NIMBLE = 8,
#endif
ORC = 9,
};

Expand Down

0 comments on commit bf954a4

Please sign in to comment.