Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Responsys: ignore 404s on delete endpoint #5203

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Oracle Responsys: ignore 404s on delete endpoint #5203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
466648e
fix: ignore 404s on delete endpoints
RobertKeyser Aug 15, 2024
b5c2d5f
docs: CHANGELOG.md update for #5203
RobertKeyser Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ The types of changes are:

## [Unreleased](https://github.com/ethyca/fides/compare/2.43.0...main)

### Fixed
- Ignore `404` errors on Oracle Responsys deletions [#5203](https://github.com/ethyca/fides/pull/5203)

## [2.43.0](https://github.com/ethyca/fides/compare/2.42.1...2.43.0)

Expand Down
2 changes: 1 addition & 1 deletion data/saas/config/oracle_responsys_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ saas_config:
name: Oracle Responsys
type: oracle_responsys
description: A sample schema representing the Oracle Responsys connector for Fides
version: 0.0.2
version: 0.0.3

connector_params:
- name: domain
Expand Down
3 changes: 2 additions & 1 deletion ...s/api/service/saas_request/override_implementations/oracle_responsys_request_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ def oracle_responsys_profile_list_recipients_delete(
SaaSRequestParams(
method=HTTPMethod.DELETE,
path=f"/rest/api/v1.3/lists/{list_id}/members/{responsys_id}",
)
),
[404],
)

rows_deleted += 1
Expand Down