Oracle Responsys: ignore 404s on delete endpoint
#5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents race conditions when duplicate requests are submitted or the responsys user is deleted outside of Fides
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
RobertKeyser
changed the title
404s on delete endpoints404s on delete endpoint
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5203 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 362 362
Lines 22741 22741
Branches 3026 3026
=======================================
Hits 19685 19685
Misses 2511 2511
Partials 545 545 ☔ View full report in Codecov by Sentry. |
galvana
approved these changes
Aug 15, 2024
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Roger-Ethyca
pushed a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FIDES-1070
Description Of Changes
This prevents race conditions when duplicate requests are submitted or the responsys user is deleted outside of Fides
Code Changes
oracle_responsys_profile_list_recipients_deleteSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works