Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove categories for country/province on Shopify integration due to field protections #5202

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −9
Draft

Remove categories for country/province on Shopify integration due to field protections #5202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c59da4
fix: remove categories for country/province due to field protections
SteveDMurphy Aug 15, 2024
dec9838
docs: changelog
SteveDMurphy Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ The types of changes are:

## [Unreleased](https://github.com/ethyca/fides/compare/2.43.0...main)

### Fixed
- Updates the default Shopify integration dataset to no longer mask country due to field protections [#5202](https://github.com/ethyca/fides/pull/5202)

## [2.43.0](https://github.com/ethyca/fides/compare/2.42.1...2.43.0)

Expand Down
2 changes: 1 addition & 1 deletion data/saas/config/shopify_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ saas_config:
type: shopify
description: A sample schema representing the Shopify connector for Fides
user_guide: https://docs.ethyca.com/user-guides/integrations/saas-integrations/shopify
version: 0.0.4
version: 0.0.5

connector_params:
- name: domain
Expand Down
16 changes: 8 additions & 8 deletions data/saas/dataset/shopify_dataset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,11 +754,11 @@ dataset:
fidesops_meta:
data_type: string
- name: province
data_categories: [user.contact.address.state]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: country
data_categories: [user.contact.address.country]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: last_name
Expand Down Expand Up @@ -786,11 +786,11 @@ dataset:
fidesops_meta:
data_type: string
- name: country_code
data_categories: [user.contact.address.country]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: province_code
data_categories: [user.contact.address.state]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: customer
Expand Down Expand Up @@ -1349,11 +1349,11 @@ dataset:
fidesops_meta:
data_type: string
- name: province
data_categories: [user.contact.address.state]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: country
data_categories: [user.contact.address.country]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: zip
Expand All @@ -1369,11 +1369,11 @@ dataset:
fidesops_meta:
data_type: string
- name: province_code
data_categories: [user.contact.address.state]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: country_code
data_categories: [user.contact.address.country]
data_categories: [system.operations]
fidesops_meta:
data_type: string
- name: country_name
Expand Down