Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove categories for country/province on Shopify integration due to field protections #5202

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SteveDMurphy
Copy link
Contributor

Closes FIDES-1131

Description Of Changes

This was found during an implementation, where the dataset had field protections. In the case of the country, it's a reasonable requirement to maintain this information or have it follow an ISO standard. Any change could also have an impact if changed (i.e. default all to US or similar) in case of warranty issues or other

Code Changes

  • Update the offending fields in customer_orders and customer_addresses

Steps to Confirm

  • Tested on a client implementation

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 4:52pm

@SteveDMurphy SteveDMurphy self-assigned this Aug 15, 2024
@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-fides-1131-shopify-api-country branch from a1a0bfd to dec9838 Compare August 15, 2024 16:51
Copy link

cypress bot commented Aug 15, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit abfa2d044f ℹ️
Started Aug 15, 2024 5:05 PM
Ended Aug 15, 2024 5:06 PM
Duration 00:42 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (b1544ff) to head (dec9838).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5202   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         362      362           
  Lines       22741    22741           
  Branches     3026     3026           
=======================================
  Hits        19685    19685           
  Misses       2511     2511           
  Partials      545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants