Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Complete backport of OWNERS file #18448

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

thedtripp
Copy link
Member

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thedtripp, thanks for your pull request. I see that there's still a mention of the MAINTAINERS file in the README.md:

etcd/README.md

Line 174 in 1956a47

A security vulnerability can be reported as an issue, however, GitHub and mailing lists may NOT always be an appropriate place for reporting vulnerabilities. In that case, please reach out to the project [MAINTAINERS](https://github.com/etcd-io/etcd/blob/master/MAINTAINERS) to first discuss the vulnerabilities with them and take necessary action per such discussion.

And there's also the MAINTAINERS_RULE.md file, which may be irrelevant with OWNERS (https://github.com/etcd-io/etcd/blob/1956a4783e316ed4b9f64e67d4451e5ce50377a5/MAINTAINERS_RULES.md). But I'm not sure what others think.

@thedtripp
Copy link
Member Author

Hi @thedtripp, thanks for your pull request. I see that there's still a mention of the MAINTAINERS file in the README.md:

etcd/README.md

Line 174 in 1956a47

A security vulnerability can be reported as an issue, however, GitHub and mailing lists may NOT always be an appropriate place for reporting vulnerabilities. In that case, please reach out to the project [MAINTAINERS](https://github.com/etcd-io/etcd/blob/master/MAINTAINERS) to first discuss the vulnerabilities with them and take necessary action per such discussion.

And there's also the MAINTAINERS_RULE.md file, which may be irrelevant with OWNERS (https://github.com/etcd-io/etcd/blob/1956a4783e316ed4b9f64e67d4451e5ce50377a5/MAINTAINERS_RULES.md). But I'm not sure what others think.

Fixed. Let me know if anything else needs attention.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for finishing this off @thedtripp

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Daniel.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, thedtripp
Once this PR has been reviewed and has the lgtm label, please assign fanminshi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 0b9e171 into etcd-io:release-3.4 Aug 16, 2024
18 checks passed
@ivanvc
Copy link
Member

ivanvc commented Aug 22, 2024

/retitle [3.4] Complete backport of OWNERS file

@k8s-ci-robot k8s-ci-robot changed the title Complete backport of OWNERS file. [3.4] Complete backport of OWNERS file Aug 22, 2024
@ivanvc ivanvc mentioned this pull request Aug 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants