-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Complete backport of OWNERS file #18448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thedtripp, thanks for your pull request. I see that there's still a mention of the MAINTAINERS
file in the README.md
:
Line 174 in 1956a47
A security vulnerability can be reported as an issue, however, GitHub and mailing lists may NOT always be an appropriate place for reporting vulnerabilities. In that case, please reach out to the project [MAINTAINERS](https://github.com/etcd-io/etcd/blob/master/MAINTAINERS) to first discuss the vulnerabilities with them and take necessary action per such discussion. |
And there's also the MAINTAINERS_RULE.md
file, which may be irrelevant with OWNERS
(https://github.com/etcd-io/etcd/blob/1956a4783e316ed4b9f64e67d4451e5ce50377a5/MAINTAINERS_RULES.md). But I'm not sure what others think.
Signed-off-by: D Tripp <[email protected]>
c6b0a69
to
eec63af
Compare
Fixed. Let me know if anything else needs attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for finishing this off @thedtripp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Daniel.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, thedtripp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [3.4] Complete backport of OWNERS file |
#16367