-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Bump go toolchain to 1.22.6 #18445
Conversation
Reference: - etcd-io#18443 Signed-off-by: Chun-Hung Tseng <[email protected]>
/retest |
1 similar comment
/retest |
The first part of the issue with the functional tests is that there's a trailing whitespace in the key of the map here (which was very obscure to find; note the Line 39 in 5161b74
It should be m[HTTPPrefixPProf+"/trace"] = http.HandlerFunc(pprof.Trace) After fixing that, there are still more test failures 😅 |
Reference: - etcd-io#18445 (comment) Signed-off-by: Chun-Hung Tseng <[email protected]> Signed-off-by: Ivan Valdes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Henry.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for digging into this @ivanvc !! It's actually the only part besides the linter issue which blocked the CI! |
Yes, I realized later that some local changes were the cause of my other errors 🙊 |
/retitle [3.4] Bump go toolchain to 1.22.6 |
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.