Revert "etcd server shouldn't wait for the ready notification infinitely on startup" #16677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
revert-13525
branch
2 times, most recently
from
f508bcc
to
d9940a5
Compare
serathius
force-pushed
the
revert-13525
branch
from
d9940a5
to
1a91ae7
Compare
ahrtr
approved these changes
Oct 2, 2023
serathius
force-pushed
the
revert-13525
branch
from
1a91ae7
to
fc6af6c
Compare
|
Reverting to draft due to TestInPlaceRecovery failing. Potentially will need to redesign the test. |
serathius
force-pushed
the
revert-13525
branch
6 times, most recently
from
ee41c0f
to
4fddf45
Compare
…ely on startup" This reverts commit 1713dc6. Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
revert-13525
branch
from
4fddf45
to
e31de5e
Compare
|
PTAL @ahrtr |
Part of the test cases in cluster_proxy.go were added before the 1713dc6, pls at least raise a followup. |
|
Done, #16690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #16666
This reverts commit 1713dc6.
cc @ahrtr @spzala @jmhbnz @wenjiaswe